Commit 3bddbafa authored by Ben Wagner's avatar Ben Wagner Committed by Kevin Funk

Fix overloaded-virtual of computeCompletions.

MissingIncludeCompletionWorker::computeCompletions causes an overloaded-virtual warning when building kdevelop. Upon investigation, it appears that it was intended to override CodeCompletionWorker::computeCompletions, but the third parameter is incorrect.

KDevelop was crashing left and right and with this change seems a bit more stable.

REVIEW: 111347
parent 12672c98
......@@ -208,9 +208,9 @@ void MissingIncludeCompletionWorker::doSpecialProcessing(unsigned int data) {
emit foundDeclarations(QList<KSharedPtr<KDevelop::CompletionTreeElement> >(), KDevelop::CodeCompletionContext::Ptr());
}
void MissingIncludeCompletionWorker::computeCompletions(KDevelop::DUContextPointer _context, const KTextEditor::Cursor& position, KTextEditor::View* view, const KTextEditor::Range& contextRange, const QString& contextText) {
void MissingIncludeCompletionWorker::computeCompletions(KDevelop::DUContextPointer _context, const KTextEditor::Cursor& position, QString followingText, const KTextEditor::Range& contextRange, const QString& contextText) {
Q_UNUSED(position);
Q_UNUSED(view);
Q_UNUSED(followingText);
Q_UNUSED(contextRange);
Q_UNUSED(contextText);
QMutexLocker mLock(&mutex);
......
......@@ -82,7 +82,7 @@ class MissingIncludeCompletionWorker : public KDevelop::CodeCompletionWorker {
virtual void abortCurrentCompletion();
virtual void doSpecialProcessing(unsigned int data);
protected:
virtual void computeCompletions(KDevelop::DUContextPointer context, const KTextEditor::Cursor& position, KTextEditor::View* view, const KTextEditor::Range& contextRange, const QString& contextText);
virtual void computeCompletions(KDevelop::DUContextPointer context, const KTextEditor::Cursor& position, QString followingText, const KTextEditor::Range& contextRange, const QString& contextText);
};
}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment