1. 20 Nov, 2018 2 commits
  2. 24 Aug, 2018 1 commit
  3. 08 Aug, 2018 1 commit
    • Morten Volden's avatar
      Fix GCC warning · 48e2d83c
      Morten Volden authored
      Summary: Fix catching polymorphic type ‘class svn::ClientException’ by value [-Wcatch-value=] on GCC
      
      Reviewers: #kdevelop, aaronpuchert
      
      Reviewed By: #kdevelop, aaronpuchert
      
      Subscribers: aaronpuchert, kdevelop-devel
      
      Tags: #kdevelop
      
      Differential Revision: https://phabricator.kde.org/D14678
      48e2d83c
  4. 27 Jul, 2018 1 commit
    • Friedrich W. H. Kossebau's avatar
      subversion plugin: fix ThreadWeaver job lifetime race condition · a873e19b
      Friedrich W. H. Kossebau authored
      Summary:
      The old code had the internal ThreadWeaver job being killed via the QObject
      child memory management from the outer KJob-based job object.
      Though this was done based on a signal emitted from the ThreadWeaver
      execution thread, when the internal ThreadWeaver job was still going to be
      used by the internal reference in the execution completion code.
      
      While the actual current ThreadWeaver code then is not accessing any member
      data and just using the pointer to the otherwisse already deleted object,
      this at least is not liked by ASan which detects a heap-use-after-free,
      resulting e.g. in failing unit tests on CI now and then.
      
      This patch fixes this by passing the ThreadWeaver job instance via a
      QSHaredPointer which then is shared by both the parent KJob and the
      ThreadWeaver Queue, so the deletion will be done by the last one handling
      it.
      
      Test Plan: Subversion plugin still works for what I tested, unit tests still pass.
      
      Reviewers: #kdevelop, mwolff
      
      Reviewed By: #kdevelop, mwolff
      
      Subscribers: mwolff, kdevelop-devel
      
      Tags: #kdevelop
      
      Differential Revision: https://phabricator.kde.org/D14413
      a873e19b
  5. 17 May, 2018 1 commit
  6. 18 Jan, 2018 1 commit
    • Christoph Roick's avatar
      Fix SVN history fetching and clean up plugin · 9fd4f6c2
      Christoph Roick authored
      Summary:
      - fetching the history of an svn project only worked sometimes
      - trying to show a diff between versions lead to a crash
      - displaying a diff from the annotation border lead to a crash
      
      - remove UI files which are not used
      - remove unused svncatjob and svncheckoutmetadatawidget
      
      Test Plan:
      - display history/log from vcs context menu entry
      - display diff from history list
      - display diff from annotation border
      - fetch svn project using the assistant
      - commit changes of an svn project
      
      Reviewers: #kdevelop, mwolff
      
      Reviewed By: #kdevelop, mwolff
      
      Subscribers: mwolff, kdevelop-devel
      
      Differential Revision: https://phabricator.kde.org/D9956
      9fd4f6c2
  7. 23 Nov, 2017 1 commit
    • Friedrich W. H. Kossebau's avatar
      Drop unfinished support for binary & before/after diffs from VcsDiff · 36fd6bf0
      Friedrich W. H. Kossebau authored
      Summary:
      VcsDiff and IBasicVersionControl::diff(...) many years ago got initial
      support for requesting and storing raw copies of files changed in a
      revision.
      
      Nothing in KDevelop though makes use of that feature, and all the VCS
      plugins themselves do not support it either, even ignore explicit requests.
      
      To ease maintainance of the used and working code for creating unified
      text diffs, this patch drops the dead code for that unfinished feature.
      When someone ever starts working on it again, the needed structures
      in VcsDiff can be easily readded and also done matching whatever approach
      is taken then.
      
      After the initial support was introduced in 2007 by e.g. commits
      5ffc3c23 and 7b09fc2f
      no further related work was ever commited to the codebase.
      
      SvnDiffJob even has initial code for fetching full before-versions of
      the affected files. But this seems premature test code which accidentally
      got committed, as the full copies are always fetched and stored
      additionally to the unified diff, and without respecting the diff type
      parameter passed to the method. Also were the after-versions not stored,
      and no other code also has ever been fetching those full copies
      from the returned VcsDiff object.
      
      Worse, most other VCS plugins simply ignored the diff type parameter passed
      to the IBasicVersionControl::diff(...) method, and always returned a
      unified diff, rendering the type parameter useless.
      
      Reviewers: #kdevelop, apol
      
      Reviewed By: #kdevelop, apol
      
      Subscribers: kdevelop-devel
      
      Differential Revision: https://phabricator.kde.org/D8962
      36fd6bf0
  8. 13 Sep, 2017 1 commit
  9. 06 Sep, 2017 1 commit
  10. 05 Sep, 2017 1 commit