1. 25 Feb, 2019 1 commit
  2. 29 Dec, 2018 1 commit
  3. 28 Dec, 2018 1 commit
  4. 17 Dec, 2018 1 commit
  5. 20 Nov, 2018 2 commits
  6. 28 Oct, 2018 1 commit
  7. 26 Oct, 2018 1 commit
  8. 25 Oct, 2018 2 commits
  9. 24 Oct, 2018 2 commits
  10. 23 Oct, 2018 1 commit
    • Friedrich W. H. Kossebau's avatar
      Generate all kdebugsettings .categories files automatically · 774429d0
      Friedrich W. H. Kossebau authored
      Summary:
      Adds two wrapping variants of the macros
      declare_qt_logging_category() & install_qt_logging_categories()
      which have an argument TYPE to control specific behaviour that
      otherwise is generalized in the wrapping macros to not have to repeat
      any things with every macro call and to ensure consistency, e.g. in
      the used description texts.
      
      The wrapper macros also handle linking things by the matching EXPORT ids,
      so the caller does not have to care for this.
      
      No perfect solution yet, but at least a first working approach to automatic
      generation of the kdebugsettings files.
      
      Test Plan:
      Generated categories files contain same ids with same descriptions as
      before.
      
      Reviewers: #kdevelop, kfunk
      
      Reviewed By: #kdevelop, kfunk
      
      Subscribers: kfunk, apol, kdevelop-devel
      
      Tags: #kdevelop
      
      Differential Revision: https://phabricator.kde.org/D16032
      774429d0
  11. 05 Oct, 2018 1 commit
  12. 22 Sep, 2018 2 commits
  13. 09 Sep, 2018 1 commit
  14. 06 Sep, 2018 1 commit
  15. 03 Sep, 2018 1 commit
  16. 31 Aug, 2018 1 commit
  17. 30 Aug, 2018 1 commit
  18. 29 Aug, 2018 2 commits
  19. 28 Aug, 2018 1 commit
  20. 27 Aug, 2018 1 commit
  21. 26 Aug, 2018 1 commit
  22. 24 Aug, 2018 2 commits
  23. 21 Aug, 2018 1 commit
  24. 17 Aug, 2018 1 commit
  25. 15 Aug, 2018 2 commits
  26. 08 Aug, 2018 1 commit
    • Morten Volden's avatar
      Fix GCC warning · 48e2d83c
      Morten Volden authored
      Summary: Fix catching polymorphic type ‘class svn::ClientException’ by value [-Wcatch-value=] on GCC
      
      Reviewers: #kdevelop, aaronpuchert
      
      Reviewed By: #kdevelop, aaronpuchert
      
      Subscribers: aaronpuchert, kdevelop-devel
      
      Tags: #kdevelop
      
      Differential Revision: https://phabricator.kde.org/D14678
      48e2d83c
  27. 27 Jul, 2018 2 commits
    • Friedrich W. H. Kossebau's avatar
      Enable warnings zero-as-null-pointer-constant & suggest-override · 416cd815
      Friedrich W. H. Kossebau authored
      Reviewers: #kdevelop, aaronpuchert
      
      Reviewed By: #kdevelop, aaronpuchert
      
      Subscribers: aaronpuchert, kdevelop-devel
      
      Tags: #kdevelop
      
      Differential Revision: https://phabricator.kde.org/D14212
      416cd815
    • Friedrich W. H. Kossebau's avatar
      subversion plugin: fix ThreadWeaver job lifetime race condition · a873e19b
      Friedrich W. H. Kossebau authored
      Summary:
      The old code had the internal ThreadWeaver job being killed via the QObject
      child memory management from the outer KJob-based job object.
      Though this was done based on a signal emitted from the ThreadWeaver
      execution thread, when the internal ThreadWeaver job was still going to be
      used by the internal reference in the execution completion code.
      
      While the actual current ThreadWeaver code then is not accessing any member
      data and just using the pointer to the otherwisse already deleted object,
      this at least is not liked by ASan which detects a heap-use-after-free,
      resulting e.g. in failing unit tests on CI now and then.
      
      This patch fixes this by passing the ThreadWeaver job instance via a
      QSHaredPointer which then is shared by both the parent KJob and the
      ThreadWeaver Queue, so the deletion will be done by the last one handling
      it.
      
      Test Plan: Subversion plugin still works for what I tested, unit tests still pass.
      
      Reviewers: #kdevelop, mwolff
      
      Reviewed By: #kdevelop, mwolff
      
      Subscribers: mwolff, kdevelop-devel
      
      Tags: #kdevelop
      
      Differential Revision: https://phabricator.kde.org/D14413
      a873e19b
  28. 07 Jul, 2018 1 commit
  29. 17 May, 2018 1 commit
  30. 23 Apr, 2018 1 commit
  31. 19 Apr, 2018 2 commits