1. 06 May, 2019 7 commits
    • Morten Volden's avatar
      revert commit 75af1881. Besides having some... · 610c3094
      Morten Volden authored
      revert commit 75af1881. Besides having some bad sideeffects on the unittest of path, it is also not the way to remove asserts on Windows when compiled in debug mode. In order to fix that we need to do something in Documentcontroller
      610c3094
    • Daniel Mensinger's avatar
      f6b9c447
    • Daniel Mensinger's avatar
      meson: Only configure if necessary · b306b0f7
      Daniel Mensinger authored
      b306b0f7
    • Daniel Mensinger's avatar
      meson: implemented project reloding · 0596b384
      Daniel Mensinger authored
      0596b384
    • Gleb Popov's avatar
      Fix deadlock exception in FileManagerListJob. · 73fb3cd6
      Gleb Popov authored
      It was visible on FreeBSD with following backtrace:
      
          frame #0: 0x0000000802b8b370 libcxxrt.so.1`::__cxa_throw(void *, std::type_info *, void (*)(void *)) at exception.cc:790
          frame #1: 0x0000000802b59c8c libc++.so.1`std::__1::__throw_system_error at system_error.cpp:289
          frame #2: 0x0000000802b4a9cd libc++.so.1`std::__1::mutex::lock at mutex.cpp:34
          frame #3: 0x00000008017b3f9e libKDevPlatformProject.so.54`KDevelop::FileManagerListJob::startNextJob at filemanagerlistjob.cpp:114
          frame #4: 0x00000008017b5b2e libKDevPlatformProject.so.54`_ZN9QtPrivate11FunctorCallINS_11IndexesListIJEEENS_4ListIJEEEvMN8KDevelop18FileManagerListJobEFvvEE4callES8_PS6_PPv at qobjectdefs_impl.h:152
          frame #5: 0x00000008017b5aa3 libKDevPlatformProject.so.54`_ZN9QtPrivate15FunctionPointerIMN8KDevelop18FileManagerListJobEFvvEE4callINS_4ListIJEEEvEEvS4_PS2_PPv at qobjectdefs_impl.h:185
          frame #6: 0x00000008017b59c6 libKDevPlatformProject.so.54`_ZN9QtPrivate11QSlotObjectIMN8KDevelop18FileManagerListJobEFvvENS_4ListIJEEEvE4implEiPNS_15QSlotObjectBaseEP7QObjectPPvPb at qobjectdefs_impl.h:414
          frame #7: 0x0000000803e2caa6 libQt5Core.so.5`QtPrivate::QSlotObjectBase::call at qobjectdefs_impl.h:394
          frame #8: 0x0000000803e66648 libQt5Core.so.5`QMetaCallEvent::placeMetaCall at qobject.cpp:518
          frame #9: 0x0000000803e68249 libQt5Core.so.5`QObject::event at qobject.cpp:1260
          frame #10: 0x0000000802e819e1 libQt5Widgets.so.5`QApplicationPrivate::notify_helper + 273
          frame #11: 0x0000000802e82f28 libQt5Widgets.so.5`QApplication::notify + 632
          frame #12: 0x0000000803e1640e libQt5Core.so.5`QCoreApplication::notifyInternal2 at qcoreapplication.cpp:1060
          frame #13: 0x0000000803e17048 libQt5Core.so.5`QCoreApplication::sendEvent at qcoreapplication.cpp:1450
          frame #14: 0x0000000803e17cce libQt5Core.so.5`QCoreApplicationPrivate::sendPostedEvents at qcoreapplication.cpp:1799
          frame #15: 0x0000000803e16f4f libQt5Core.so.5`QCoreApplication::sendPostedEvents at qcoreapplication.cpp:1653
          frame #16: 0x0000000803ec630e libQt5Core.so.5`postEventSourceDispatch at qeventdispatcher_glib.cpp:276
          frame #17: 0x0000000805b52b77 libglib-2.0.so.0`g_main_context_dispatch + 311
          frame #18: 0x0000000805b52f03 libglib-2.0.so.0`___lldb_unnamed_symbol117$$libglib-2.0.so.0 + 515
          frame #19: 0x0000000805b52fb4 libglib-2.0.so.0`g_main_context_iteration + 100
          frame #20: 0x0000000803ec5485 libQt5Core.so.5`QEventDispatcherGlib::processEvents at qeventdispatcher_glib.cpp:422
          frame #21: 0x0000000803e112f9 libQt5Core.so.5`QEventLoop::processEvents at qeventloop.cpp:138
          frame #22: 0x0000000803e1154f libQt5Core.so.5`QEventLoop::exec at qeventloop.cpp:225
          frame #23: 0x000000080027e464 libKDevPlatformTests.so.54`KDevelop::KDevSignalSpy::wait at kdevsignalspy.cpp:48
          frame #24: 0x00000000002114ad test_definesandincludes`(anonymous namespace)::loadProject at projectsgenerator.cpp:47
          frame #25: 0x0000000000211047 test_definesandincludes`ProjectsGenerator::GenerateSimpleProject at projectsgenerator.cpp:105
          frame #26: 0x0000000000208914 test_definesandincludes`TestDefinesAndIncludes::loadSimpleProject at test_definesandincludes.cpp:56
          frame #27: 0x00000000002083d9 test_definesandincludes`TestDefinesAndIncludes::qt_static_metacall at moc_test_definesandincludes.cpp:96
          frame #28: 0x0000000803e25ed9 libQt5Core.so.5`QMetaMethod::invoke at qmetaobject.cpp:2295
          frame #29: 0x00000008002c31f9 libQt5Test.so.5`___lldb_unnamed_symbol8$$libQt5Test.so.5 + 825
          frame #30: 0x00000008002c3bef libQt5Test.so.5`___lldb_unnamed_symbol9$$libQt5Test.so.5 + 815
          frame #31: 0x00000008002c4989 libQt5Test.so.5`___lldb_unnamed_symbol12$$libQt5Test.so.5 + 745
          frame #32: 0x00000008002c517c libQt5Test.so.5`QTest::qRun + 156
          frame #33: 0x00000008002c4ef4 libQt5Test.so.5`QTest::qExec + 20
          frame #34: 0x000000000020a562 test_definesandincludes`main at test_definesandincludes.cpp:152
          frame #35: 0x000000000020811b test_definesandincludes`_start at crt1.c:76
      73fb3cd6
    • Amish Naidu's avatar
      clang: Fix completion tests by using documentController to create view · 6dca2d31
      Amish Naidu authored
      Implement/override completion tests now use DocumentChangeSet which
      relies on CodeRepresentation to make changes, if we don't use a view
      through the global document controller, a disk file code representation
      is created which doesn't update the kate view.
      6dca2d31
    • Amish Naidu's avatar
      clang: Use DocumentChangeSet for code completion in some places · 34c34c77
      Amish Naidu authored
      Using DocumentChangeSet enables auto formatting.
      34c34c77
  2. 04 May, 2019 1 commit
  3. 01 May, 2019 1 commit
  4. 30 Apr, 2019 4 commits
  5. 24 Apr, 2019 1 commit
  6. 23 Apr, 2019 2 commits
  7. 19 Apr, 2019 1 commit
    • Christian Tacke's avatar
      DVCS Branch Manager with filtering and sorting proposal · 8f77f44b
      Christian Tacke authored
      Summary:
      The porposal is to utilize QSortFilterProxyModel for sorting and filtering.
      
      When working with on a bigger project with multiple branches some means to find a desired branch for switching or creating a new branch may be considered helpful.
      So I added a line edit and a QSortFilterProxyModel to do that for me.
      
      Additionally: new branches are currently appended. Though this makes them easy to find, I think it's counter intuitive and a tad ugly. While the sort mechanism of the Proxy does not help initially, it does upon adding branches.
      
      Drawback: the line edit for filtering may be associated with the "New" button by users. This could make the workflow for that less intuitive.
      
      Test Plan:
      Fire up Git->Branches on a git project.
      
      Make sure all branches are there.
      Type in the line edit to filter. Only branches that match should be included.
      Clearing the line edit should result in all elements to become visible again.
      Create New branch, that should be added to list in alphabetical order.
      
      Reviewers: apol
      
      Reviewed By: apol
      
      Subscribers: kfunk, apol, kdevelop-devel
      
      Tags: #vdg, #kdevelop
      
      Differential Revision: https://phabricator.kde.org/D20142
      8f77f44b
  8. 14 Apr, 2019 4 commits
    • Milian Wolff's avatar
      Also find clang include path based on runtime libclang library path · bc13f955
      Milian Wolff authored
      My KDevelop was compiled against my system libclang v7.0.1, thus
      KDEV_CLANG_BUILTIN_DIR points to /usr/lib/clang/7.0.1/include. Now
      I compiled clang 8 from sources and put it in a different folder
      in my home path and adapted LD_LIBRARY_PATH to make KDevelop pick it
      up. This then fails to find the builtin include path, since it tries
      to find `/usr/lib/clang/8.0.1/include` which doesn't exit.
      
      This patch adds another fallback to fix the above scneario: We now
      lookup the path of libclang at runtime through dlfcn.h's dladdr,
      which we pass a libclang function address, here clang_getClangVersion.
      Then on success we deduce the include path by removing the library
      name and then instead appending `clang/$version/include`, which makes
      it use /home/milian/projects/compiled/other/lib/clang/8.0.1/include
      as required.
      bc13f955
    • Milian Wolff's avatar
      clang: add new (partially failing) test file for lambdas · c88bf19b
      Milian Wolff authored
      We apparently fail to build uses for lambda captures using
      C++14 `identifier initializer` statements. Turns out that the
      init-capture isn't visited by libclang, see also:
      
      https://reviews.llvm.org/D60672
      c88bf19b
    • Milian Wolff's avatar
      Simplify setting custom parser args for unit tests · d8119c13
      Milian Wolff authored
      Make it possible to add parser args from a background provider and
      share the test provider implementation.
      d8119c13
    • Milian Wolff's avatar
      clang: fix functions.cpp test · bbb42a2f
      Milian Wolff authored
      Potentially this got fixed/changed by a newer clang version
      bbb42a2f
  9. 13 Apr, 2019 1 commit
  10. 10 Apr, 2019 1 commit
  11. 09 Apr, 2019 1 commit
  12. 06 Apr, 2019 1 commit
  13. 02 Apr, 2019 1 commit
  14. 01 Apr, 2019 2 commits
  15. 31 Mar, 2019 1 commit
  16. 25 Mar, 2019 4 commits
  17. 20 Mar, 2019 2 commits
    • Thibault North's avatar
      CMake: discover more unit tests · d5e3e27b
      Thibault North authored
      Discover unit-tests using bracket arguments and/or listed in
      files other than CTestTestFile.cmake:
      
      When using gtest_discover_tests(), add_test() directives are present
      in various .cmake files. To date, Kdevelop searches for unit-tests
      does not follow include() directives present in the main
      CTestTestfile.cmake, leading to no unit-tests being shown.
      Additionally, the bracket arguments of CMake is not enabled for
      parsing tests arguments.
      
      This patch enables them, and follows include() directives.
      
      Reviewers: apol, kfunk, mwolff
      Reviewed By: mwolff
      Subscribers: mwolff, kdevelop-devel
      Tags: #kdevelop
      BUG: 405225
      Differential Revision: https://phabricator.kde.org/D19673
      d5e3e27b
    • Script Kiddy's avatar
      SVN_SILENT made messages (.desktop file) - always resolve ours · a19629cc
      Script Kiddy authored
      In case of conflict in i18n, keep the version of the branch "ours"
      To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
      a19629cc
  18. 19 Mar, 2019 1 commit
  19. 11 Mar, 2019 2 commits
  20. 08 Mar, 2019 2 commits