The branch for Qt < 5.14.0 had a ')' too much...
Wolfgang Bauer (c2eba863) at 17 Nov 13:57
Fix build with older Qt versions
Oops, sorry, I'm not fully on-topic here... I was actually referring to a similar build error/warning (about KSaneCore not being found) when building other applications that use libksane, not when building libksane itself.
Something seems to be wrong here though.
KSaneCore is actually marked as PRIVATE
in https://invent.kde.org/graphics/libksane/-/blob/master/src/CMakeLists.txt#L55, so it shouldn't be needed to build against libksane.
I.e. probably either KSaneCore should be a PUBLIC
link target, or the dependency be removed, I suppose.
See !11 (merged) .
Fix build with Akonadi 21.12
Commit b9d91006 adjusted the includes to changes in akonadi(-notes), but that broke compilation with the currently released versions.
Wolfgang Bauer (17f373bb) at 01 Apr 08:00
Fix build with Akonadi 21.12
Wolfgang Bauer (13187db5) at 03 Jan 19:32
Fix destination filesystem type check for downloads bigger than 4 GiB
PS: here's a link to the docs: https://doc.qt.io/qt-5/qtglobal.html, https://doc.qt.io/qt-5/qtglobal.html#QT_VERSION, https://doc.qt.io/qt-5/qtglobal.html#QT_VERSION_CHECK
To quote:
The header file includes the fundamental global declarations. It is included by most other Qt header files.
#if QT_VERSION >= QT_VERSION_CHECK(5, 13, 0)
here in this file should work, yes.
(I actually tested it)
Both QT_VERSION
and QT_VERSION_CHECK()
are defined in qglobals.h .
Unfortunately, this doesn't fully work as expected AFAICT.
You'd need to #include <qtguiversion.h>
(or #include <QtGuiVersion>
), otherwise QTGUI_VERSION
is undefined and the #else branch is always taken (in C++'s #if
, a symbol is treated as 0 if it's undefined; the compiler does warn here: "warning: "QTGUI_VERSION" is not defined, evaluates to 0 [-Wundef]").
Or, it should also be sufficient to use QT_VERSION instead which should always be defined.
As apparently nobody did it until now, and kexi master still depends on the .rcc, here it is finally: https://bugs.kde.org/show_bug.cgi?id=446731
It's a remnant from an older time and doesn't make sense today
Wolfgang Bauer (0012b007) at 26 Jul 13:14
Remove commented parameters
Yeah, should be fine I suppose.
Wolfgang Bauer (003064ad) at 17 Jul 20:00
Fix typo Detatched -> Detached