Skip to content
  • Aleix Pol Gonzalez's avatar
    (WIP) Upgrade Telephony plugin to read SMS history (KDE side) · 31e93ef7
    Aleix Pol Gonzalez authored and Simon Redman's avatar Simon Redman committed
    Summary:
    For real usecases of SMS support, we will almost always need access to the message history in some way
    
    Specifically resolve T8338
    
    Incidentally resolve T6651 since Telephony shall no longer create a notification
    
    Test Plan:
    Setup:
    - Build corresponding Android-side diff (D11698)
    - Build this diff
    
    Step 1: Does anything at all work?
    - Put a breakpoint in the handleBatchMessages method of the telephony plugin, ideally after constructing a Message object
    - Use DBus to poke /modules/kdeconnect/devices/<deviceID>/telephony.requestAllConversations()
    - Verify that the constructed Message is one you sent or received and that it is the most recent in the corresponding conversation
    
    Step 2: DBus
    - Open the Interface org.kde.kdeconnect.device.conversations of /modules/kdeconnect/devices/<deviceId>
    - Poke activeConversations and verify an empty array is returned
    - Poke requestAllConversationThreads
    - Poke activeConversations and verify that a list of numbers has been returned. These are conversationIds
    - Use a conversationId to call getFirstFromConversation
      - Verify that the returned Message object is one which you recognize
      - Note that if the message is an MMS it will be blank and meaningless. Try a different conversationId. MMS support "coming soon!"
    
    Step 3: SMS App
    - Use ccmake (or similar) to set SMSAPP_ENABLE to ON
    - Build the project
    - Run ./bin/kdeconnect-sms
    - Verify that the app shows a list of everyone you have an SMS conversation with (MMS messages are stripped out)
      - If you have the Contacts plugin working, verify that most contacts have their name and photo instead of their phone number
    
    Reviewers: #kde_connect, nicolasfella, apol
    
    Reviewed By: #kde_connect, nicolasfella, apol
    
    Subscribers: andyholmes, apol, nicolasfella, #kde_connect
    
    Tags: #kde_connect
    
    Maniphest Tasks: T8338, T6651
    
    Differential Revision: https://phabricator.kde.org/D11854
    31e93ef7