1. 17 Mar, 2018 1 commit
  2. 16 Mar, 2018 1 commit
    • Friedrich W. H. Kossebau's avatar
      MPRIS control: do not accumulate interface objects · 72fc67ee
      Friedrich W. H. Kossebau authored
      Summary:
      If MPRIS players were appearing and disappearing multiple times, the
      OrgFreedesktopDBusPropertiesInterface & OrgMprisMediaPlayer2PlayerInterface
      instances created for listening to the signals had been accumulating and
      thus resulting in X signals per X restarted player, because the instances
      were not deleted when a player disappeared.
      Additionally were instances of them created on the fly on the stack in
      some of the methods, instead of reusing the existing ones.
      
      This patch changes that by introducing a class MprisPlayer which holds all
      data & instances per player. This allows to look up the respective
      interfaces instances to reuse them as well as properly controlling their
      lifetime.
      
      Test Plan:
      Starting and restarting multiple MPRIS players (incl. multiple instances of
      the same player app) works as expected as befire. They are listed on the
      Android Media control as well as have proper states there when selected.
      Additionally no longer multiple change signals are emitted if restarting a
      player.
      
      Reviewers: #kde_connect, mtijink
      
      Reviewed By: #kde_connect, mtijink
      
      Subscribers: mtijink
      
      Differential Revision: https://phabricator.kde.org/D11389
      72fc67ee
  3. 15 Mar, 2018 1 commit
  4. 14 Mar, 2018 1 commit
  5. 13 Mar, 2018 2 commits
  6. 12 Mar, 2018 1 commit
  7. 05 Mar, 2018 1 commit
  8. 04 Mar, 2018 1 commit
  9. 03 Mar, 2018 1 commit
  10. 27 Feb, 2018 1 commit
    • Matthijs Tijink's avatar
      Add more scripting helpers to cli command · cc072e4a
      Matthijs Tijink authored
      Summary:
      Adds "--name-only" and "--id-name-only", in addition to the already existing "--id-only".
      
      This is useful for the zsh autocompletion which I've written.
      
      Test Plan: The output is identical without the new flags.
      
      Reviewers: #kde_connect, nicolasfella
      
      Reviewed By: #kde_connect, nicolasfella
      
      Differential Revision: https://phabricator.kde.org/D10875
      cc072e4a
  11. 26 Feb, 2018 1 commit
  12. 17 Feb, 2018 3 commits
  13. 04 Feb, 2018 1 commit
    • Nicolas Fella's avatar
      Tweak KCM · aeb4eeff
      Nicolas Fella authored
      Summary: Tweaking the text a little leads to a window size that doesn't cut off the refresh button when no device is selected.
      
      Test Plan:
      Before:
      
      {F5691067}
      
      After:
      
      {F5691069}
      
      Reviewers: #kde_connect, albertvaka
      
      Reviewed By: #kde_connect, albertvaka
      
      Subscribers: #kde_connect
      
      Tags: #kde_connect
      
      Differential Revision: https://phabricator.kde.org/D10287
      aeb4eeff
  14. 30 Jan, 2018 1 commit
  15. 29 Jan, 2018 1 commit
  16. 28 Jan, 2018 2 commits
  17. 27 Jan, 2018 1 commit
  18. 25 Jan, 2018 1 commit
  19. 22 Jan, 2018 2 commits
  20. 16 Jan, 2018 3 commits
  21. 09 Jan, 2018 1 commit
  22. 07 Jan, 2018 1 commit
  23. 03 Jan, 2018 2 commits
  24. 30 Dec, 2017 1 commit
    • Matthijs Tijink's avatar
      Add title, artist and album to MPRIS network packets · 71d8eb07
      Matthijs Tijink authored
      Summary: This diff adds the title, artist and album to the MPRIS network packets. That's useful when you need more detail than just "artist - title", for example in the future media control notification. It also fixes weird song descriptions for empty artist strings (e.g. Spotify uses an empty (but present) artist when playing ads)
      
      Reviewers: #kde_connect, apol
      
      Reviewed By: #kde_connect, apol
      
      Subscribers: nicolasfella, apol
      
      Differential Revision: https://phabricator.kde.org/D8957
      71d8eb07
  25. 29 Dec, 2017 1 commit
  26. 22 Dec, 2017 1 commit
  27. 11 Dec, 2017 1 commit
  28. 09 Dec, 2017 1 commit
  29. 03 Dec, 2017 2 commits
    • Matthijs Tijink's avatar
      Fix kdeconnect-cli device list · 6a6b97e7
      Matthijs Tijink authored
      Summary:
      Previously, the .devices() call passed the parameters in the wrong order. I checked the order in the interface and the daemon, and this was the only place it went wrong.
      
      Now running `kdeconnect-cli -l` correctly lists all paired devices, even if unreachable.
      
      Test Plan: Tested with both a reachable and unreachable device.
      
      Reviewers: #kde_connect, apol
      
      Reviewed By: #kde_connect, apol
      
      Subscribers: apol
      
      Differential Revision: https://phabricator.kde.org/D9060
      6a6b97e7
    • Matthijs Tijink's avatar
      Fix "error activiting kdeconnectd" for kdeconnect-cli · 227e2640
      Matthijs Tijink authored
      Summary:
      Kdeconnect-cli always displayed one or more "error activating kdeconnectd: QDBusError("", "")" messages.
      
      This diff uses the reply of starting the kdeconnect daemon correctly, so this does not happen anymore.
      
      Test Plan: Kdeconnect-cli and the daemon still work, but kdeconnect-cli does not show the error message anymore. I verified that if, for some reason, the daemon could not start, it does display an error.
      
      Reviewers: #kde_connect, apol
      
      Reviewed By: #kde_connect, apol
      
      Subscribers: apol
      
      Differential Revision: https://phabricator.kde.org/D9058
      227e2640
  30. 29 Nov, 2017 1 commit
    • David Edmundson's avatar
      Delay kdeconnectd autostart phase · 71bf898d
      David Edmundson authored
      Summary:
      This value maps to KAutostart::StartPhase
      
      kdeconnectd is certainly not BaseDesktop which is "essential desktop
      services" which is at the same level as plasmashell.
      
      This delays it into DesktopServices which is slightly later.
      
      For a user this won't change a thing, it'll still be loaded before
      ksplash is removed.
      
      Test Plan: None
      
      Differential Revision: https://phabricator.kde.org/D9031
      71bf898d
  31. 28 Nov, 2017 1 commit