1. 31 Jan, 2019 2 commits
  2. 27 Jan, 2019 3 commits
  3. 26 Jan, 2019 4 commits
  4. 25 Jan, 2019 2 commits
    • Heiko Becker's avatar
      Use KAboutData to set information about the daemon · fab782d9
      Heiko Becker authored
      Summary:
      I noticed this when the daemon crashed and drkonqi refused to submit
      a bug report, complaining about a missing bug reporting address.
      Additionally, using KAboutData also saves initialising some
      properties of QCoreApplication manually.
      
      Test Plan:
      sent SIGSEGV to kdeconnect, could've reported the crash
      with drkonqi; checked with GammaRay that the properties of
      QCoreApplication are initialised.
      
      Reviewers: #kde_connect
      
      Subscribers: kdeconnect
      
      Tags: #kde_connect
      
      Differential Revision: https://phabricator.kde.org/D18542
      fab782d9
    • Script Kiddy's avatar
      SVN_SILENT made messages (.desktop file) - always resolve ours · 864c83ff
      Script Kiddy authored
      In case of conflict in i18n, keep the version of the branch "ours"
      To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
      864c83ff
  5. 24 Jan, 2019 5 commits
  6. 23 Jan, 2019 3 commits
    • Nicolas Fella's avatar
      Merge branch 'master' into 'master' · a880e91d
      Nicolas Fella authored
      Add basic Merge Request templates
      
      See merge request kde/kdeconnect-kde!2
      a880e91d
    • Simon Redman's avatar
      Add basic Merge Request templates · 72898be7
      Simon Redman authored
      72898be7
    • Simon Redman's avatar
      [SMS App] Make sms app not crash when conversation is selected with no devices connected · a14b39d5
      Simon Redman authored
      Summary: This patch fixes T10184 and stops the SMS app from crashing when a conversation is selected but no devices are connected. It also allows the SMS app to access the cached messages in the ConversationsDbusInterface so the app is still slightly useful even when the device is disconnected.
      
      Test Plan:
      - Open sms app
      - Open a few conversations
      - Disconnect phone (Force close app?)
      - Re-open a conversation which was previously opened
        - Verify that the messages appear. It is possible to scroll up to view any older cached messages too!
      - Open a conversation which was not opened previously
        - Verify that a single messages is shown (since this was the only one in cache, from populating the list of all conversations)
        - Verify that attempting to scroll this conversation does nothing, but also does not crash the app
      
      Note: Opening the app with no phone connected will cause it to lose its handle on the deviceId, so it can't spawn a new Dbus interface, so it will remain blank and empty. Solving that is a project for another day.
      
      Reviewers: #kde_connect
      
      Reviewed By: #kde_connect
      
      Subscribers: apol, nicolasfella, kdeconnect
      
      Tags: #kde_connect
      
      Maniphest Tasks: T10184
      
      Differential Revision: https://phabricator.kde.org/D17634
      a14b39d5
  7. 22 Jan, 2019 1 commit
  8. 21 Jan, 2019 1 commit
    • Simon Redman's avatar
      Cache and delete old ConversationsDbusInterfaces to avoid memory leak · 74ba660c
      Simon Redman authored
      Summary:
      After using the ConversationsDbusInterface for a little while, there can be significant (MBs) memory usage of cached messages. The QDBusAbstractAdaptor does not like to be manually deleted, but it looks like it is safe to do so after constructing a new one
      
      This contradicts the comment in the BatteryPlugin and the BatteryDbusInterface, which says deletelater() is not safe. Has Qt been updated since then?
      
      Test Plan:
      - Run daemon
      - Hopefully experience no crashes after many phone reconnects
      
      Reviewers: #kde_connect, apol, albertvaka
      
      Reviewed By: #kde_connect, apol, albertvaka
      
      Subscribers: apol, kdeconnect
      
      Tags: #kde_connect
      
      Differential Revision: https://phabricator.kde.org/D16553
      74ba660c
  9. 19 Jan, 2019 1 commit
    • Matthijs Tijink's avatar
      Add description of bluetooth multiplexing protocol · e77c1c87
      Matthijs Tijink authored
      Summary:
      As mentioned on telegram, there are some fundamental issues with bluetooth. The only approach I could get working was multiplexing: manually sending multiple streams of data over a single connection.
      
      This is the description of that multiplexing protocol. I have an implementation of this protocol, but I'd first like some feedback to see if this is what we're going to use before finishing up those patches.
      
      See the document itself for more details. I make the protocol forward-compatible, although I don't expect we will need ever that.
      
      Test Plan: None, this is just a description.
      
      Reviewers: #kde_connect, andyholmes, albertvaka
      
      Reviewed By: #kde_connect, albertvaka
      
      Subscribers: albertvaka, kdeconnect
      
      Tags: #kde_connect
      
      Differential Revision: https://phabricator.kde.org/D17987
      e77c1c87
  10. 18 Jan, 2019 1 commit
    • Nicolas Fella's avatar
      Allow newer TLS versions · 1b20ecec
      Nicolas Fella authored
      Summary:
      Instead of mandating TLS V1.0 use 1.0 or later.
      BUG: 400338
      
      Test Plan: Phone connects
      
      Reviewers: #kde_connect, albertvaka
      
      Reviewed By: #kde_connect, albertvaka
      
      Subscribers: thomasp, kdeconnect
      
      Tags: #kde_connect
      
      Differential Revision: https://phabricator.kde.org/D18217
      1b20ecec
  11. 16 Jan, 2019 1 commit
    • Erik Duisters's avatar
      Just set UDSEntry::UDS_NAME to the actual directory name instead of the... · 4834b635
      Erik Duisters authored
      Just set UDSEntry::UDS_NAME to the actual directory name instead of the hardcoded string "folder" and don't set UDSEntry::UDS_DISPLAY_NAME at all
      
      Summary: There is no reason to set UDSEntry::UDS_NAME to "folder" and then override it with UDSEntry::UDS_DISPLAY_NAME
      
      Test Plan:
      Apply patch, click android device in dolphin's Devices list
      Verify phones sdcards are listed as befor
      
      Reviewers: #kde_connect, albertvaka
      
      Reviewed By: #kde_connect, albertvaka
      
      Subscribers: albertvaka, kdeconnect
      
      Tags: #kde_connect
      
      Differential Revision: https://phabricator.kde.org/D18223
      4834b635
  12. 14 Jan, 2019 1 commit
  13. 09 Jan, 2019 1 commit
  14. 06 Jan, 2019 2 commits
    • Erik Duisters's avatar
      Do not close m_socket in socketError() · 9f5cdf1a
      Erik Duisters authored
      Summary:
      When android closes the payload socket (cancel share) calling m_socket.close() results
      in a recursive call to onError eventually leading to a segmentation violation
      
      Test Plan:
      Install D16491, share a large file from desktop to android and cancel the share on Android through
       the notification. kdeconnectd crashes almost 100% of the time. (It doesn't crash when it detects
       a disconnect in sendNextPacket)
      
      Reviewers: #kde_connect, nicolasfella
      
      Reviewed By: #kde_connect, nicolasfella
      
      Subscribers: kdeconnect
      
      Tags: #kde_connect
      
      Differential Revision: https://phabricator.kde.org/D17628
      9f5cdf1a
    • Script Kiddy's avatar
      SVN_SILENT made messages (.desktop file) - always resolve ours · 71c5a1b2
      Script Kiddy authored
      In case of conflict in i18n, keep the version of the branch "ours"
      To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
      71c5a1b2
  15. 02 Jan, 2019 1 commit
    • Simon Redman's avatar
      Implement Drag n Drop file transfer on the plasmoid · bafbc344
      Simon Redman authored
      Summary:
      A DropArea has been added to the ListItem representing a device in the
      plasmoid based on what is done in the Quickshare plasmoid. This enables
      Drag n Drop of files onto a section of the plasmoid to transfer files.
      
      The DropArea has the size of the ListItem which is a rectangle
      including the title of the device down to the button to share text.
      Additionally, there is a tooltip area covering the DropArea to indicate
      that it is possible to drop a file to send it to the device. Multiple files
      can be sent at once.
      
      Ref T8288
      
      Test Plan: Drag and Drop one or many files onto the widget, the files should be transferred to the connected device.
      
      Reviewers: #kde_connect, sredman
      
      Reviewed By: #kde_connect, sredman
      
      Subscribers: sredman, kdeconnect
      
      Tags: #kde_connect
      
      Maniphest Tasks: T8288
      
      Differential Revision: https://phabricator.kde.org/D17611
      bafbc344
  16. 31 Dec, 2018 1 commit
    • Matthijs Tijink's avatar
      Add handling for the identity packet to be split across two messages. · 97551d09
      Matthijs Tijink authored
      Summary: If the identity packet is split across two packets, then save it until we get a notification that more data is available for reading over the bluetooth link.
      
      Test Plan: Connect a phone and laptop over Bluetooth, and verify that both the phone and laptop are able to see each other, and that either side can start and successfully go through the pairing process.
      
      Reviewers: #kde_connect, mtijink
      
      Reviewed By: #kde_connect, mtijink
      
      Subscribers: mtijink, kdeconnect
      
      Tags: #kde_connect
      
      Differential Revision: https://phabricator.kde.org/D17789
      97551d09
  17. 29 Dec, 2018 1 commit
  18. 25 Dec, 2018 4 commits
  19. 24 Dec, 2018 2 commits
  20. 23 Dec, 2018 1 commit
  21. 21 Dec, 2018 1 commit
    • Jun Bo Bi's avatar
      [mpriscontrol] add primitive windows support · f4c7e12e
      Jun Bo Bi authored
      Summary: Added primitive support for the mpriscontrol plugin on Windows by simulating VK_MEDIA key presses. I took a look into `ISystemMediaTransportControls`, but there doesn't seem to query it since it's per app. Leaving simulating key presses our only option for now. Completes T10000
      
      Reviewers: kdeconnect, #kde_connect, albertvaka
      
      Reviewed By: #kde_connect, albertvaka
      
      Subscribers: albertvaka
      
      Tags: #kde_connect, #windows
      
      Maniphest Tasks: T10000
      
      Differential Revision: https://phabricator.kde.org/D17702
      f4c7e12e
  22. 18 Dec, 2018 1 commit