1. 02 Nov, 2018 1 commit
    • Nicolas Fella's avatar
      Add contract file · 9a56d753
      Nicolas Fella authored
      Summary:
      This allows sending files from ElementaryOS apps such as their file manager.
      
      Create a data dir for similar files
      
      Test Plan: run contractor; run pantheon-files, right-click file -> Send via KDE Connect
      
      Reviewers: #kde_connect
      
      Subscribers: kdeconnect
      
      Tags: #kde_connect
      
      Differential Revision: https://phabricator.kde.org/D16603
      9a56d753
  2. 01 Nov, 2018 3 commits
  3. 31 Oct, 2018 4 commits
    • Billy Laws's avatar
      Add QML support for shareplugin · 5c86da54
      Billy Laws authored
      Summary: This will allow it to be used in the plasmoid and QML app via dbus.
      
      Reviewers: nicolasfella
      
      Reviewed By: nicolasfella
      
      Subscribers: kdeconnect
      
      Tags: #kde_connect
      
      Differential Revision: https://phabricator.kde.org/D16551
      5c86da54
    • Nicolas Fella's avatar
      Add editorconfig file · bf03990b
      Nicolas Fella authored
      Summary: editorconfig is a cross-editor way of keeping basic coding style standards, e.g. indentation
      
      Reviewers: #kde_connect, albertvaka
      
      Reviewed By: #kde_connect, albertvaka
      
      Subscribers: apol, albertvaka, sredman, kdeconnect
      
      Tags: #kde_connect
      
      Differential Revision: https://phabricator.kde.org/D16533
      bf03990b
    • Nicolas Fella's avatar
      Don't use deprecated ApplicationHeader · 1359a9c0
      Nicolas Fella authored
      Summary:
      Use the implicit header
      
      This makes the Add commands action show up in the top bar on desktop
      
      Desktop
      {F6375830}
      
      Mobile
      {F6375831}
      
      Reviewers: #kde_connect, apol
      
      Reviewed By: #kde_connect, apol
      
      Subscribers: kdeconnect
      
      Tags: #kde_connect
      
      Differential Revision: https://phabricator.kde.org/D16548
      1359a9c0
    • Simon Redman's avatar
      [SMS App] Clean up runtime warning about undefined behavior · 70926fbe
      Simon Redman authored
      Summary: Move ColumnLayout containing text elements inside of the graphical bounding rectangle
      
      Test Plan:
      Pre patch:
       - Launch messaging app
       - Open conversation
       - Notice huge spew of warnings like: "qrc:/qml/ChatMessage.qml:84:5: QML ColumnLayout: Detected anchors on an item that is managed by a layout. This is undefined behavior; use Layout.alignment instead."
      Post patch:
       - Launch messaging app
       - Open conversation
       - No warnings about undefined behavior
      
      Reviewers: apol
      
      Reviewed By: apol
      
      Subscribers: kdeconnect
      
      Tags: #kde_connect
      
      Differential Revision: https://phabricator.kde.org/D16534
      70926fbe
  4. 30 Oct, 2018 5 commits
  5. 29 Oct, 2018 2 commits
    • Simon Redman's avatar
      Make NetworkPacket Metatype-capable · 0f5c9cd9
      Simon Redman authored
      Summary: I am open to discussion for whether this is desireable. The use-case is for moving NetworkPacket receive handling to a thread other than the one handling the rest of the device. In order to do this, we need to use a QtConnectionType::QueuedConnection. In order for that to work (with NetworkPackets), NetworkPacket has to be registered in the Metatype system.
      
      Test Plan: Nothing should be functionally different from before
      
      Reviewers: #kde_connect, albertvaka
      
      Reviewed By: #kde_connect, albertvaka
      
      Subscribers: albertvaka, apol, nicolasfella, kdeconnect
      
      Tags: #kde_connect
      
      Differential Revision: https://phabricator.kde.org/D16469
      0f5c9cd9
    • Simon Redman's avatar
      Properly Assign LanLinkProvider as the Parent of its child objects · 08b31ce2
      Simon Redman authored
      Summary: This is not a hugely important change. I noticed it while I was working on something else, and it seems like it ought to be this way
      
      Test Plan: Nothing should be noticeably different
      
      Reviewers: #kde_connect, albertvaka
      
      Reviewed By: #kde_connect, albertvaka
      
      Subscribers: apol, kdeconnect
      
      Tags: #kde_connect
      
      Differential Revision: https://phabricator.kde.org/D16468
      08b31ce2
  6. 28 Oct, 2018 1 commit
  7. 27 Oct, 2018 1 commit
    • Alex Kovrigin's avatar
      Improve "No devices" warning · 4daf129c
      Alex Kovrigin authored
      Summary:
      Move the "No devices available" text in smsapp from combobox to the ConversationList.
      
      P.S.
      It's a GCI task.
      
      Test Plan:
      * Build and run smsapp
      * Try pairing and unpairing the device
      * See the difference
      
      Reviewers: #kde_connect, sredman
      
      Reviewed By: #kde_connect, sredman
      
      Subscribers: sredman, kdeconnect
      
      Tags: #kde_connect
      
      Differential Revision: https://phabricator.kde.org/D16467
      4daf129c
  8. 26 Oct, 2018 1 commit
    • Simon Redman's avatar
      Fix include guards · b01652f5
      Simon Redman authored
      Summary:
      Some plugins were copy/pasted from a template and forgot to change their include guards. Since plugin header files are never cross-referenced, this was not a serious issue, but it looks nicer to be correct
      
      NotificationListener.h did not have an include guard. As before, this is not a problem currently, but it's best to have it fixed
      
      Test Plan: Project should build, compile, and run as normal
      
      Reviewers: #kde_connect, nicolasfella
      
      Reviewed By: #kde_connect, nicolasfella
      
      Subscribers: kdeconnect
      
      Tags: #kde_connect
      
      Differential Revision: https://phabricator.kde.org/D16437
      b01652f5
  9. 24 Oct, 2018 1 commit
  10. 23 Oct, 2018 2 commits
    • Adam Pigg's avatar
      use libkeepalive to wakeup daemon · ee52c8cd
      Adam Pigg authored
      Summary:
      Main change is to use libkeepalive to wake up the system to ensure connections stay alive
      
      Other minor changes are:
      -Log daemon messages for debugging purposes
      -Add way to forece refresh of device list
      -Minor spec improvements
      
      The keepalive changes certainly seem to help, not sure if it completely solves the problems
      The logging changes are temporary, and I could use them locally, but they only affect sailfish users
      Im not sure if the refresh method is correct, but seems to force the daemon to check for devices
      
      Reviewers: #kde_connect, nicolasfella, albertvaka
      
      Reviewed By: #kde_connect, albertvaka
      
      Subscribers: kdeconnect
      
      Tags: #kde_connect
      
      Differential Revision: https://phabricator.kde.org/D15414
      ee52c8cd
    • Script Kiddy's avatar
      SVN_SILENT made messages (.desktop file) - always resolve ours · a98533b8
      Script Kiddy authored
      In case of conflict in i18n, keep the version of the branch "ours"
      To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
      a98533b8
  11. 11 Oct, 2018 2 commits
  12. 10 Oct, 2018 2 commits
  13. 08 Oct, 2018 5 commits
    • Nicolas Fella's avatar
      Don't show phonenumber if name is available · 8bfe0939
      Nicolas Fella authored
      Summary:
      Showing the number next to the name is neither pretty nor necessary IMHO.
      
      My Android SMS app displays the number more subtle in an extra line below in gray. I could get behind something similar, but until this is implemented just don't show it
      
      Depends on D16015
      
      Reviewers: #kde_connect, sredman
      
      Reviewed By: #kde_connect, sredman
      
      Subscribers: sredman, kdeconnect
      
      Tags: #kde_connect
      
      Differential Revision: https://phabricator.kde.org/D16017
      8bfe0939
    • Nicolas Fella's avatar
      Fix person name displaying in ConversationDisplay · 45e966c2
      Nicolas Fella authored
      Summary: Don't ask my why this works this way
      
      Test Plan: I see Name: phonenumber for contacts and just phonenumber for non-contacts now
      
      Reviewers: #kde_connect, sredman
      
      Reviewed By: #kde_connect, sredman
      
      Subscribers: sredman, kdeconnect
      
      Tags: #kde_connect
      
      Differential Revision: https://phabricator.kde.org/D16015
      45e966c2
    • Aleix Pol Gonzalez's avatar
    • Simon Redman's avatar
      [Desktop] Update conversation list when a new message arrives · a7db3ab5
      Simon Redman authored
      Summary:
      When a new message is delivered, the conversation list should update by changing the preview text and re-sorting the conversations
      
      Bonus bug discovered and fixed:  previously, when the conversations list was being populated, it made a request for the first message in every conversation. This would be fine if the conversationdbusinterface pulled from local cache. However, this actually triggers a request to the phone for *every* conversation.
      
      This should be handled differently in conversationdbusinterface's requestConversation as well, but that's a project for a later day (TODO comments added)
      
      Test Plan:
       - Launch SMS app
       - Verify conversations list appears
       - Verify lack of massive stream of debug output indicating lots of messages for the wrong conversation are being received
       - Verify that opening a particular conversation shows the messages after a short delay while the backend fetches the content from the phone
       - Verify that receiving a new message into an existing conversation updates the conversation list
      
      Reviewers: #kde_connect, nicolasfella
      
      Reviewed By: #kde_connect, nicolasfella
      
      Subscribers: nicolasfella, apol, kdeconnect
      
      Tags: #kde_connect
      
      Differential Revision: https://phabricator.kde.org/D15608
      a7db3ab5
    • Simon Redman's avatar
      [SMS App] Improve contact matching · ab33cce5
      Simon Redman authored
      Summary: Improve contact matching by checking if the requested address ends with a candidate phone number, or vice-versa
      
      Test Plan:
      Check that *all* conversations which correspond to a contact are matched
       - All of mine match. If someone finds one which doesn't, I will need the particulars...
      
      Reviewers: #kde_connect, nicolasfella
      
      Reviewed By: #kde_connect, nicolasfella
      
      Subscribers: nicolasfella, kdeconnect
      
      Tags: #kde_connect
      
      Differential Revision: https://phabricator.kde.org/D15992
      ab33cce5
  14. 07 Oct, 2018 2 commits
  15. 05 Oct, 2018 1 commit
  16. 04 Oct, 2018 2 commits
  17. 30 Sep, 2018 1 commit
  18. 29 Sep, 2018 1 commit
  19. 28 Sep, 2018 2 commits
    • Nicolas Fella's avatar
      [cli] Allow sharing files and URLs together · 7a4bdcc6
      Nicolas Fella authored
      Summary:
      Depends on D15787
      
      Restricting sharing multiple urls to files seems unnecessary to me.
      
      Test Plan: kdeconnect-cli --share foo.txt google.com
      
      Reviewers: #kde_connect, apol
      
      Reviewed By: #kde_connect, apol
      
      Subscribers: apol, kdeconnect
      
      Tags: #kde_connect
      
      Differential Revision: https://phabricator.kde.org/D15788
      7a4bdcc6
    • Nicolas Fella's avatar
      [cli] Always take working dir into account when parsing url · 51825134
      Nicolas Fella authored
      Summary:
      Bug: 399115
      
      When using kdeconnect-cli --share the first argument was not recognised as a file when a relative path was specified.
      
      Test Plan:
      kdeconnect-cli --share File1.txt File2.txt : Check that both files are sent
      kdeconnect-cli --sahre phabricator.kde.org : Check that web page is opend
      
      Reviewers: #kde_connect, apol
      
      Reviewed By: #kde_connect, apol
      
      Subscribers: apol, kdeconnect
      
      Tags: #kde_connect
      
      Differential Revision: https://phabricator.kde.org/D15787
      51825134
  20. 27 Sep, 2018 1 commit
    • Nicolas Fella's avatar
      Merge icon CMake macros · e9323452
      Nicolas Fella authored
      Summary: If there was any reason to have it split please enlighten me
      
      Test Plan: Remove icons from hicolor folder. sudo make install. Check for installed icons
      
      Reviewers: #kde_connect, apol
      
      Reviewed By: #kde_connect, apol
      
      Subscribers: kdeconnect
      
      Tags: #kde_connect
      
      Differential Revision: https://phabricator.kde.org/D15765
      e9323452