1. 29 Sep, 2019 1 commit
  2. 07 Aug, 2019 1 commit
  3. 29 Jul, 2019 1 commit
  4. 21 Jul, 2019 1 commit
  5. 20 Jul, 2019 1 commit
  6. 19 Jul, 2019 2 commits
    • Simon Redman's avatar
      [SMS App] Handle addresses for multitarget messages · edee0e0e
      Simon Redman authored
      ## Summary
      
      Upgrade the SMS App to handle multitarget addresses in the "addresses" field of a message and drop usage of the "address" field
      
      Also note that this has all the commits from https://invent.kde.org/kde/kdeconnect-kde/merge_requests/97, but I will rebase those away once that patch is landed
      
      Bonus: Image composition for multitarget conversations
      
      ## Test Plan
      - Apply Android-side patch https://invent.kde.org/kde/kdeconnect-android/merge_requests/80
      - Launch SMS App
      - Notice that you can see all the recipients of multitarget messages. (Replying still not supported, but might get implemented as part of fixing replying to single-target messages)
      edee0e0e
    • Simon Redman's avatar
      [SMS App] Basic plain-text MMS support · ee9547ed
      Simon Redman authored
      ## Summary
      
      Desktop companion to https://invent.kde.org/kde/kdeconnect-android/merge_requests/78
      
      Give desktop SMS app a basic understanding of the MMSes coming from Android:
      - Show a fake body if we get an attachment we can't display (for now, any attachment)
      - Display a fake contact header for multi-target messages since Android does not yet export multi-target address information
      - Disable attempting to reply to multi-target messages
      
      BUG: 398889
      
      ## Test Plan
      ### Before:
      MMS messages were silently dropped, meaning:
       - Group MMS conversations were not visible
       - Single-target conversations with the most-recent message an MMS were not visible
      
      ### After:
       - Install https://invent.kde.org/kde/kdeconnect-android/merge_requests/78
       - Multi-target conversations are displayed (kind of ugly, since they have no contact information
       - Single-target conversations which end with an MMS are displayed
       - Plain-text MMS is displayed nicely
       - MMS attachments don't show
         - MMS which are only an attachment with no body are displayed with a dummy body
      ee9547ed
  7. 29 Jun, 2019 1 commit
  8. 12 Jun, 2019 1 commit
  9. 10 Jun, 2019 1 commit
  10. 08 May, 2019 1 commit
  11. 01 May, 2019 3 commits
  12. 22 Apr, 2019 1 commit
  13. 29 Mar, 2019 1 commit
  14. 23 Mar, 2019 1 commit
  15. 07 Mar, 2019 1 commit
  16. 28 Feb, 2019 1 commit
  17. 31 Jan, 2019 1 commit
  18. 25 Jan, 2019 1 commit
  19. 23 Jan, 2019 1 commit
    • Simon Redman's avatar
      [SMS App] Make sms app not crash when conversation is selected with no devices connected · a14b39d5
      Simon Redman authored
      Summary: This patch fixes T10184 and stops the SMS app from crashing when a conversation is selected but no devices are connected. It also allows the SMS app to access the cached messages in the ConversationsDbusInterface so the app is still slightly useful even when the device is disconnected.
      
      Test Plan:
      - Open sms app
      - Open a few conversations
      - Disconnect phone (Force close app?)
      - Re-open a conversation which was previously opened
        - Verify that the messages appear. It is possible to scroll up to view any older cached messages too!
      - Open a conversation which was not opened previously
        - Verify that a single messages is shown (since this was the only one in cache, from populating the list of all conversations)
        - Verify that attempting to scroll this conversation does nothing, but also does not crash the app
      
      Note: Opening the app with no phone connected will cause it to lose its handle on the deviceId, so it can't spawn a new Dbus interface, so it will remain blank and empty. Solving that is a project for another day.
      
      Reviewers: #kde_connect
      
      Reviewed By: #kde_connect
      
      Subscribers: apol, nicolasfella, kdeconnect
      
      Tags: #kde_connect
      
      Maniphest Tasks: T10184
      
      Differential Revision: https://phabricator.kde.org/D17634
      a14b39d5
  20. 21 Jan, 2019 1 commit
    • Simon Redman's avatar
      Cache and delete old ConversationsDbusInterfaces to avoid memory leak · 74ba660c
      Simon Redman authored
      Summary:
      After using the ConversationsDbusInterface for a little while, there can be significant (MBs) memory usage of cached messages. The QDBusAbstractAdaptor does not like to be manually deleted, but it looks like it is safe to do so after constructing a new one
      
      This contradicts the comment in the BatteryPlugin and the BatteryDbusInterface, which says deletelater() is not safe. Has Qt been updated since then?
      
      Test Plan:
      - Run daemon
      - Hopefully experience no crashes after many phone reconnects
      
      Reviewers: #kde_connect, apol, albertvaka
      
      Reviewed By: #kde_connect, apol, albertvaka
      
      Subscribers: apol, kdeconnect
      
      Tags: #kde_connect
      
      Differential Revision: https://phabricator.kde.org/D16553
      74ba660c
  21. 09 Jan, 2019 1 commit
  22. 14 Dec, 2018 1 commit
  23. 13 Dec, 2018 3 commits
    • Simon Redman's avatar
      [SMS App] Allow scrolling up to load and display older messages · 2c35c1af
      Simon Redman authored
      Summary:
      Scroll up to show older messages
      
      Newly received messages will not force the view to the bottom unless the new message is being added "very close" to the visible area
      
      Test Plan:
      Message History:
       - Open conversation
       - Scroll/Drag up to load older messages
      
      New Message:
       - Open conversation
       - Scroll to bottom
       - Verify that a newly-received or newly-sent message is added to the GUI
       - Scroll up
       - Verify that sending/receiving a message does not disturb the view
       - Scroll back to verify that the new message was indeed added to the list
      
      Reviewers: #kde_connect, apol
      
      Reviewed By: #kde_connect, apol
      
      Subscribers: apol, nicolasfella, kdeconnect
      
      Tags: #kde_connect
      
      Maniphest Tasks: T9556
      
      Differential Revision: https://phabricator.kde.org/D15979
      2c35c1af
    • Simon Redman's avatar
    • Simon Redman's avatar
      [SMS App] Make requestMoreMessages asynchronous, blocking, and caching · 019e8d6a
      Simon Redman authored
      Summary:
      The most serious change from this patch is to move the asynchronous replying to a request from the app for more messages to a newly-spawned, self-destructing thread. Within that thread, we block until the remote device replies with the requested messages.
      
      All gotten messages are cached in the ConversationDbusInterface, so all future requests are fast and don't hit the remote device.
      
      Test Plan: After applying this diff, the messaging app should show 10 messages every time it is opened
      
      Reviewers: #kde_connect, nicolasfella, albertvaka
      
      Reviewed By: #kde_connect, albertvaka
      
      Subscribers: albertvaka, apol, nicolasfella, kdeconnect
      
      Tags: #kde_connect
      
      Differential Revision: https://phabricator.kde.org/D16475
      019e8d6a
  24. 12 Dec, 2018 1 commit
    • Simon Redman's avatar
      [Desktop] Change ThreadID to long · 5cdfb9b0
      Simon Redman authored
      Summary: Change ThreadID to long
      
      Test Plan:
      Messages should send and receive as before. Additionally, if your device has assigned extremely large ThreadIDs, the SMS plugin should no longer crash.
      
      This patch corresponds to the Android-side revision D17517
      
      Reviewers: #kde_connect, nicolasfella
      
      Reviewed By: #kde_connect, nicolasfella
      
      Subscribers: nicolasfella, kdeconnect
      
      Tags: #kde_connect
      
      Differential Revision: https://phabricator.kde.org/D17516
      5cdfb9b0
  25. 11 Dec, 2018 1 commit
  26. 03 Dec, 2018 1 commit
  27. 26 Nov, 2018 1 commit
  28. 21 Nov, 2018 1 commit
  29. 16 Nov, 2018 1 commit
  30. 01 Nov, 2018 2 commits
  31. 28 Oct, 2018 1 commit
  32. 24 Oct, 2018 1 commit
  33. 23 Oct, 2018 1 commit
  34. 10 Oct, 2018 1 commit