GitLab

NOTE: This patch requires KNotifications 5.9

Note: This commit requires KNotifications 5.9

Tie the change signal to the getter, makes the interface easier to read
and opens the possibility to adopt certain optimizations in the Qt side.

https://marcmutz.wordpress.com/effective-qt/containers/

If deviceAdded is reported even though it's already in the model, don't
add it twice.

Off by 1 index... :(

It's the suggested data type to use according to:
https://marcmutz.wordpress.com/effective-qt/containers/

It exposed a problem later on, where we'd end up removing our own
capabilities into the remote's.

Hopefully it will make it easier to pick up at some point.

When a device is added, just add the new device instead of refreshing the
whole list.

Make the population asynchronous on dbus. Wait for the device list and
don't populate it until it's ready. There's no reason to block.
Don't emit after endInsertRows. It doesn't help, as the views will have
already refreshed.

No need to show the FullRepresentation to figure out the status of the
plasmoid.
Moves the code back to the main.qml file so that we're always tracking if
there's actually paired devices.

REVIEW: 122912

Removes the usage of RenameDialog by moving the functionality away. In
fact, what it does is make the share dialog try to come up with a different
name rather than asking the user. It's a quite common procedure as makes
the interaction simpler (for example, Chromium and Kamoso work like that).

REVIEW: 122813

Don't assume destination is local, also don't use setPath, which is quite
broken as it still keeps the scheme.
This way, destination can be any valid URL.
Don't add a trailing slash if we're going to remove it afterwards anyway.
Remove some back-and-forth conversions between QUrl and QString.

QUrl::toLocalFile is portable.

Just checking if we can get rid of QtWidgets dependency on core,
eventually

Benefits:
- We had config files in different paths, now they will be centralized.
- Daemon, LanLinkProvider and NetworkPackage depend only on Qt now.
- KConfig is accessed with strings as keys, where a typo can go unnoticed.
- Daemon is now thinner, as it doesn't need to initialize config values.
- QCA::Initializer is in a single place now (was in Daemon and Plugin).

Only look for it in the writable path, as it won't ever be installed in a
common place.
Don't look for the path in the config file either.
Don't make it depend on the application name.

REVIEW: 122744

Also:
Added some missing i18n calls.
Using QTextStream(stderr) instead of qCritical() to avoid "quoted output".