I think the favorite system works fine as it is, but with 0-5 stars enabled the voting is always showing in the Tracks middle panel which seems excessive. I don't think the feature is so important to always jump in your face with 5 star voting. I think the behavior of the Playlist is better and should be used here where you need to click the single star first before voting opens (I think that is how it was when I last time tried this as in my previous video?).
stars-middlepanel-2022-09-02_21.35.54
Unfortunately I can't test the star voting itself as I'm having some problems unrelated to this MR with file permissions.
When switched to Tracks view, bunch of qml errors that don't happen on master are printed:
qrc:/qml/ListBrowserDelegate.qml:0: ReferenceError: isValid is not defined
qrc:/qml/ListBrowserDelegate.qml:0: ReferenceError: playListEntry is not defined
Also, this behaviour feels unintuitive where the star menus stay open but hidden:
To make the album icon, text and margins in Media/SimplePlaylistView consistent with the ones in NavigationActionBar, we change the coverArtSize to Kirigami.iconSizes.medium (same which is used in Kirigami.Icon) instead of unitSpacing and the ListSectionHeader level (font size) and margin to match.
Before:
After:
Yerrey Dev (a5fb5c87) at 27 Aug 09:01
Improve consistency of UI icon sizing by moving to Kirigami iconSizes.
... and 166 more commits
Yerrey Dev (ed7d19e6) at 26 Aug 14:37
Instead of custom delegate use an inline warning for overlapping op...
... and 10 more commits
I think the warnings look bad and inconsistent due to being offset and different compared to the last warning. I could take the two first warnings out of the FormLayout to get them to span the whole width. With twinFormLayouts we can still keep the FormLayouts aligned properly. I think that would look better. What do you think?
Yerrey Dev (d0d200d0) at 26 Aug 14:00
Instead of custom delegate use an inline warning for overlapping op...
Yerrey Dev (1f496c09) at 25 Aug 21:18
Remove unusued settings and change text formatting
Yerrey Dev (7debad3a) at 22 Aug 22:14
Add KCM.ContextualHelpButton to clarify shorter ComboBox option
Only from the same folder as that was the behavior that the other music players I tested had, so that's what I went with.
It is unnecessary by function, but I think that's the easiest way to make the three ComboBoxes have consistent appearance. Another option would be to edit the custom delegate have darker coloring to match the third combobox.
One downside defining a custom delegate is that we have to start from scratch so we lose some of the functionality of the default delegate, such as pressing a key to jump to an option, like hitting "R" to jump to "Recently Played" in the dropdown menu. These could be reimplemented on the custom delegate though if accessibility is concern.
Currently the overlapping options are disabled without any indication to the user why and they need to connect the dots. I tried using QQC2.ToolTip
but it does not seem to show up on disabled elements (https://bugreports.qt.io/browse/QTBUG-30801) as the mouse events are disabled also.
EDIT: I believe the issue with the tooltip was fixed in this https://codereview.qt-project.org/c/qt/qtdeclarative/+/265576 patch which is picked to Qt 6.0 release. I'm not sure how the Qt5PatchCollection works, but if we wanted the disabled tooltip without workarounds, maybe that patch could be backported into KDE's Qt 5.15 qtdeclarative.
Yerrey Dev (f89eb27a) at 20 Aug 03:31
Merge branch 'master' of https://invent.kde.org/multimedia/elisa in...
... and 5 more commits
That is a good option, but I'm not very good with coming up with concise language. If the options were "Prefer relative paths" and "Always use absolute paths", and the contextual tool tip reads "When Prefer relative paths is selected, files in the same folder as the playlist will be referred with only the filename. Absolute paths are used in other cases." Does that seem clear?
Fixes kf.i18n: 1 instead of 0 arguments to message "Show the file for th..." supplied before conversion
error.
Yerrey Dev (cea7913e) at 19 Aug 04:00
Fix extra argument in i18n "Show in folder"
... and 158 more commits
I'm not sure if I understand this correctly as you say "alternative". If you mean that the configuration menu combo box should hide the overlapping options, that would merely be an extension to this. I can take a look at that possibility to see how messy the indexes get with hidden options.
How I read it is "when the music is in the same folder as the playlist". Another alternative could be "Use relative paths from the same folder", which could also work.
Yerrey Dev (9d682f1c) at 18 Aug 20:25
Improve variable name and add case when embed equals initial view
... and 7 more commits
Fixes the issue where the initial view opened is incorrect when an index is removed due to being an embedded category. This patch checks if embedded category is selected by calling embeddedCategory()
and assigning the index number as Nth option on the views list. If the embedded category index is less than the initial view index, we need to adjust the mInitialIndex by minus one to keep it correct. Also adds the fix when initial view is equal to embedded category and defaults it to "Now Playing" view.
SettingsForm.qml
disables the overlapping options when choosing embedded categories and initial views.