Skip to content

Change zoom shortcuts to be consistent

Mr. xk1000 requested to merge xk/krita-zoomkeys:zoom_key into master

The shortcut for zooming behaves differently whether it was bound to a mouse wheel or key. In practice, this has to be addressed via a plugin or 3rd party application, like autohotkey, custom keyboard firmware, etc.

In my case, it requires running custom firmware + another application (imwheel) to allow scrolling from one 'mouse' while another is moving around.

This patch changes the fallback position from the center of the canvas to the current mouse position, effectively making them the same.

Test Plan

  • With default bindings, use the scroll wheel to zoom
  • Use the -/= keys to zoom, ensuring it properly zooms to the cursor.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
  • Does the patch add a user-visible feature? No If yes, is there a documentation MR ready for it at Krita Documentation Repository?

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Edited by Mr. xk1000

Merge request reports