Skip to content

wayland: send dndFinished to source if target fails to do so

David Edmundson requested to merge work/d_ed/dnd_cleanup into master

After receiving a drop a client should call data_offer.finish to tell the source it's done using the drop.

A client could delete an offer after drop before calling finish.

This can happen with misbehaving/buggy or malicious Wayland clients. A real case was found in the wild with Chromium, as described in the linked bug.

In this situation we should let the source know the dnd is finished as there are no other transfers than can take place.

We don't want to universally send this in all data offer destructors only, offers that are deleted post drop so the flag on the source is exposed.

BUG: 482142

Merge request reports