• Dmitry Kazakov's avatar
    Fix a crash when creating a text shape · eb611609
    Dmitry Kazakov authored
    Every KoShapeController used to reset the global "shape document" in its
    KoDocumentResourceManager. The problem is that in Krita we have multiple
    KoShapeController-s, but the resource manager is the only one. It means
    that every shape selection or shape layer used to reset the pointer to
    the global "shape document" to its own one. The only reason why we didn't
    have too many crashes is that almost noone uses this "shape document".
    
    Ideally we should:
    1) Remove KoDocumentResourceManager::GlobalShapeController resource. This
       resource is not global to the document, but is created per-layer. The only
       user of it atm is the legacy text tool, which should be deprecated.
    
    2) Remove KoDocumentResourceManager at all. There is no much use of it
       anymore. Its main user is legacy text tool.
    
    BUG:407554
    eb611609
Name
Last commit
Last update
.github Loading commit data...
.gitlab/merge_request_templates Loading commit data...
3rdparty Loading commit data...
benchmarks Loading commit data...
build-tools Loading commit data...
cmake Loading commit data...
dev-tools/python Loading commit data...
interfaces Loading commit data...
krita Loading commit data...
libs Loading commit data...
packaging Loading commit data...
pics Loading commit data...
plugins Loading commit data...
sdk Loading commit data...
winquirks Loading commit data...
.arcconfig Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.lgtm.yml Loading commit data...
AUTHORS Loading commit data...
CMakeLists.txt Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COPYING Loading commit data...
COPYING-CMAKE-SCRIPTS Loading commit data...
CTestConfig.cmake Loading commit data...
HACKING Loading commit data...
KoAlwaysInline.h Loading commit data...
KoConfig.h.cmake Loading commit data...
Mainpage.dox Loading commit data...
Messages.sh Loading commit data...
README.md Loading commit data...
action_i18n.pl Loading commit data...
config-gsl.h.cmake Loading commit data...
config-hash-table-implementaion.h.cmake Loading commit data...
config-hdr.h.cmake Loading commit data...
config-hide-safe-asserts.h.cmake Loading commit data...
config-high-dpi-scale-factor-rounding-policy.h.in Loading commit data...
config-limit-long-tests.h.cmake Loading commit data...
config-ocio.h.cmake Loading commit data...
config-powf.h.cmake Loading commit data...
config-qtmultimedia.h.cmake Loading commit data...
config-set-has-border-in-full-screen-default.h.in Loading commit data...
config-vc.h.cmake Loading commit data...
config_convolution.h.cmake Loading commit data...
config_use_qt_tablet_windows.h.cmake Loading commit data...
extracti18n.pl Loading commit data...
kundo2_aware_xgettext.sh Loading commit data...
setup.cfg Loading commit data...