Skip to content
  • Eric Dejouhanet's avatar
    Rework scheduler startup to merge execution paths. · 46523bed
    Eric Dejouhanet authored and Jasem Mutlaq's avatar Jasem Mutlaq committed
    Summary:
    Reworked Scheduler startup functions so that all execution paths use "startJobEvaluation".
    Function "startJobEvaluation" is also called when clicking button "Only evaluate jobs".
    D-Bus interface "resetAllJobs" is altered to execute an evaluation too.
    
    Test Plan:
    In the context of starting the Scheduler, create or load a set of Scheduler Jobs.
    
    Note there is a difference in this Test Plan between full evaluation and on-th-fly evaluation:
    - Full evaluation resets the states of all Scheduler Jobs and unconditionally refreshes the capture storage.
    - On-the-fly evaluation is lighter, does not check storage, and only applies to IDLE, EVALUATION and ABORTED jobs.
    
    If loading, full evaluation is called after the XML load is successful.
    
    If creating, on-the-fly evaluation is called every time a control is updated.
    
    Not that without the fix, there is a regression with Track/Align/Focus/Guide in that context, which cannot be saved (workaround was to finish edit with a pipeline step checked).
    
    Start the Scheduler, full evaluation is called.
    This fix eliminates remaining issues with capture counts not proper in the Scheduler.
    Now the correct captured frame map is transferred to the capture module and we can start fixing things there.
    
    Reviewers: mutlaqja, wreissenberger
    
    Reviewed By: mutlaqja
    
    Subscribers: kde-edu
    
    Tags: #kde_edu
    
    Differential Revision: https://phabricator.kde.org/D14601
    46523bed