Skip to content
  • Robert Lancaster's avatar
    Improving Astrometry Conf file support for Linux and OS X · 53305c7e
    Robert Lancaster authored and Jasem Mutlaq's avatar Jasem Mutlaq committed
    Summary:
    This addresses a number of astrometry issues and adds functionality
    
    - The Astrometry Conf file option was being ignored on Linux so the user thought they were setting it but were not.
    - The internal conf file option is now available on Linux.  For awhile now, KStars on Linux has been using the internal conf file without permission
    - This update allows the conf file editor to now work on Linux too, which adds tons of flexibility.
    - Users can now create multiple directories for conf files wherever they choose
    - Users are now told beforehand and are prevented from downloading files to nonexistant directories and directories that are read only.
    - Users can now specifically choose which directory index files are going into and get a report of what is installed on each
    - Users can also get a report of all index files installed in all directories
    - Adding/changing a directory now in the conf file is easier with a file browser.
    - If there is only one path in conf file, the IndexFileDownloader should behave as before with just the one directory, if there is more than one, then you can select which directory and there is a summary view too.
    - Conf file setup is now consolidated to one file, is more simplified, and is executed earlier and any time its needed.
    - Added a check to make sure that the local conf file and directory are created before running the IndexFileDownloader
    - It checks to see if you really want to download duplicate files
    - It provides folder details now in the file download so the user knows why they can/cannot download to that folder.
    - In the conf file downloader they can now click to open a folder in the List view of the conf file editor.
    
    Test Plan:
    - Try creating a new installation on Mac and Linux with no conf file
    - Try adding other directories to the conf file both using the editor and the plus button in the conf file editor
    - Try changing other parameters in the conf file and saving.
    - Try selecting different locations in the index file downloader and downloading/deleting files
    - Try folders that don't actually exist to make sure it lets the user know and prevents the download
    - Try using the Internal Conf file and then try using an external one
    
    Reviewers: mutlaqja
    
    Reviewed By: mutlaqja
    
    Subscribers: kde-edu
    
    Tags: #kde_edu
    
    Differential Revision: https://phabricator.kde.org/D23762
    53305c7e