Skip to content

Flip focus bug

Hy Murveit requested to merge murveit/kstars:flip-focus-bug into master

I found a bug where:

  • meridian flip is about to go to FLIP_PLANNED
  • capture starts a focus on filter change, so guiding goes from guiding to suspended
  • capture gets the FLIP_PLANNED, but because guiding is suspended, it sets resumeGuidingAfterFlip to false. capture.cpp line 3636 resumeGuidingAfterFlip = isGuidingActive();
  • then focus finishes, guiding is resumed, then eventually flip happens, but because the variable is set that way, guiding doesn't get resumed.

I don't believe there's any circumstance when you'd be in guide suspended and want to stay that way across a meridian flip, so am modifying isGuidingActive to include GUIDE_SUSPENDED.

Merge request reports