Skip to content

Focus Abort Bug

John Evans requested to merge johnevans/kstars:focusabortbug into master

Bug reported by Hy whereby when a Focus Abort is requested...

  1. Focus signals the status change to Capture / Scheduler too soon which means that Capture / Scheduler can attempt to use the camera when Focus is not done with it.
  2. Focus does not interrupt its own processing securely. This results in another exposure after the abort has been partially processed. This in turn sets the focus status to Idle - which is incorrect.

There are 2 parts to this bug:

  1. If the abort request occurs whilst star processing of a focus frame is in progress, then a subsequent capture can be started after the abort processing has started.
  2. Generally the signal to capture / scheduler can occur too early in the abort processing before Focus has finished with the camera so this runs the risk of capture / scheduler starting to use the camera whilst Focus is using it leading to conflicts.

The fix will make sure that when in Autofocus, captures and HFR processing are complete (and no new ones started) before starting the internal Focus abort processing that signals Capture / Scheduler of the state change.

Edited by John Evans

Merge request reports