Skip to content

Remember to reset the meridian flip (and other) settings on exit.

Hy Murveit requested to merge murveit/kstars:polar-align-mf-fix into master

When exiting polar align, the options it changed need to be restored.

Honestly, this isn't a 100% fix. I believe it is a fix worth doing, as it will solve the problem much of the time (as long as the user explicitly exits the polar align).

However, if the use simply leaves polar align without clicking 'done' (e.g. by just clicking on the Solution Results sub-tab) then his/her flags won't be restored. Polar align should not be messing with the user's Options--there should be another way of preventing the MF. That said, it's too close to the release for me (with limited knowledge of align) to re-wire the thing. I'd recommend that someone more familiar with align refactors/re-organizes at some point so that Options::executeMeridianFlip() is never changed inside of polar align.

Merge request reports