Skip to content

Rework Focus UI button update.

Eric Dejouhanet requested to merge edejouhanet/kstars:bugfix__focus_test into master

This MR fixes the UI feedback issue in the Focus module, due to the execution of the source detection, and fixes its unitary test.

The source detection happens after the capture sequence, but the UI was only reflecting the end of the capture.

This made tests unable to get a visual feedback on the end of the HFR computation.

A few issues observed:

  • The FITS Viewer marks stars at the end of a multi-frame averaged HFR computation, but shows each frame one after the other. This results in a strange user experience.
  • The Focus module honors the multi-frame average value when searching for stars initially, while it should only search once and ask the end-user to select a star. The multi-frame average value should be used when actually computing HFR to estimate focus quality.

Merge request reports