Skip to content

Fix twilight calculation

Eric Dejouhanet requested to merge edejouhanet/kstars:bugfix__twilight into master

This MR fixes the issues encountered with dawn and dusk values.

  • Dawn and dusk calculation is reworked in KSAlmanac (no impact) and its interface slightly optimised.
  • Dawn and dusk values are integrated into SchedulerJob.
  • Scores in Scheduler are reworked to adapt, a "current" dawn and dusk is kept for scores.

The dawn/dusk issue triggered when the dusk time occurred before the dawn time. Its effect could prevent a job from starting continuously over the day.

Dawn and dusk calculation now may push a job away as much as ten days before marking the job invalid if no suitable time is found.

No tests are bundled in this MR. This will be future work based on !305 (merged).

Edited by Eric Dejouhanet

Merge request reports