Skip to content

Revamp guider UI, remove dead code

Hy Murveit requested to merge murveit/kstars:guider-fix8 into master

This is a "cleanup MR" in preparation of further changes to the internal guider UI.

There should be no functional changes (except that the user now changes his/her dither and control parameters on a different menu).

Dead code removal:

  • removed unused image guiding code
  • removed unused rapid guiding code

Below GOM stands for Guider Options Menu--that is, the menu you get by pushing the Options button on the lower right corner of the Guide page.

UI Changes:

  • Dither options used to be in GOM's Guider Tab. Now the GOM has a Dither tab for dither parameters.
  • Moved the control parameters (e.g. DEC proportional gain = 133) to the GOM's Guide tab (where dither parameters used to be).
  • Removed the Control sub-tab from the Guide page (the sub-tab next to "Drift Plot" and "Calibration Plot").
  • Removed UI controls related to image guiding and rapid guiding

Here's a screenshot of the new UI. https://photos.app.goo.gl/6H6YSDmPdNY6wUuDA

My plan is to make further changes that would impact guiding performance, e.g. use calibration motor-motion values in DEC and RA standard guiding, reduce replicated parameters between standard guiding and GPG. This is a start so that those changes can be smaller MRs.

Merge request reports