Skip to content

Adjust SEP MultiStar graphics so lines don't obscure guidestar.

Hy Murveit requested to merge murveit/kstars:guide-graphics1 into master

Overview

This is a slight change to the SEP MultiStar graphics drawn on the guideview image. Previously, when lines from the guide star to the neighbor stars were drawn, then lines went all the way from the guide star to the neighbor star. This results in some green or red lines obscuring the view of the various stars. With this change, the lines start at the guide star's reticle box and end at the circle around the neighbor stars, so mostly, stars are no longer obscured. (A neighbor can still be slightly obscured if a line to a different neighbor passes over it). This also improves the view of the guide star in the Setup/Summary tab. Here is an image of the new graphics in the guide view: https://photos.app.goo.gl/yaC1FRHQ11Hp8TNu9 and here is a view of the guide star closeup in the Setup/Summary tab: https://photos.app.goo.gl/4yf2jy88Y2jhrkQL6

I also removed the little '+' that was drawn at the exact detection location of the star, as I found it distracting and not useful.

In an unrelated change, I also added a couple lines to record the elapsed time for SEP computation in an existing qCDebug in guidestars.cpp, because I had an forum inquiry about slowness in SEP MultiStar.

Details

The main changes are in guideview.cpp in the drawNeighbor() method that implement the new line endpoints.

The changes in guidestars.cpp related to adding elapsed time to a qCDebug() for the SEP computation.

Testing

To test, start KStars and Ekos, connect to Indi, move the telescope away from the pole so that the system can guide, select SEP MultiStar as the guiding detection algorithm, start guiding. Once SEP MultiStar selects its guide stars and neighbors, you should see the graphs as shown in the link above, with the lines starting at the reticle and ending at the circle. You should also see, on the Setup/Summary tab, that the view of the guide star is not obscured by the lines. Also, the little plus signs at detection points should no longer be overlayed onto the image.

Edited by Hy Murveit

Merge request reports