Skip to content

Add popup if image write fails

Hy Murveit requested to merge murveit/kstars:capture4 into master

If the write fails, e.g. the filename/path was bad such that the image couldn't be written, then indiccd pops up a message for 60s informing the user.

I think this is a good improvement, and worthy of submission now, but not yet ideal. Please let me know how you suggest it be improved.

Issues

  • capture still doesn't know there's an issue, and continues to say "Downloading...", I imagine until the capture timeout happens.
  • the popup I chose, warningContinueCancel() isn't perfectly suited to this (it has an extra button that I set to the empty string). I chose it because it had a timeout, which I thought we should have. I set the timeout to 60s.
  • Ideally the log box at the bottom of the capture page would also get this message. I guess this would requiring wiring something through to capture--see my first point above.

Testing

You can test this by adding any capture sequence in capture, where the "Directory" field in the sequence is set to a non-writable directory, e.g. /usr/bin (presumably you're not running KStars as root, and thus should not have permission to write images into /usr/bin).

Merge request reports