Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • KStars KStars
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 82
    • Issues 82
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 9
    • Merge requests 9
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Artifacts
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • EducationEducation
  • KStarsKStars
  • Merge requests
  • !442

Fix issue where PAA is falsely disabled due to FOV

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Hy Murveit requested to merge murveit/kstars:paa-fix1 into master Sep 30, 2021
  • Overview 0
  • Commits 1
  • Pipelines 1
  • Changes 1

This fixes an issue widely reported on the forum, where polar alignment is falsely disabled due to small FOV, even though the FOV isn't small.

See, for instance, https://indilib.org/forum/ekos/10455-paa-disabled.html#76142

The issue was that the polar alignment was disabled when the FOV was too small, but it wasn't being enabled if the FOV was large enough.

I imagine it is possible that polar alignment was disabled during initialization, e.g. if calculateFOV was called before the camera parameters were known (and e.g. the pixel size was set to 0), but then never re-enabled even though the updated FOV computations showed the FOV was fine.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: paa-fix1