Skip to content

Upgrade & refactor rotatorsettings

Toni Schriber requested to merge escriban/kstars:RotatorFlipPolicy into master

  • Refactor initialize routine: Analyzing the unwanted movements of the rotator (see here and here) Jasem discovered a reaction coupling while setting the camera position angle. (Thanks again!) The approach with blocking signals works, but neglects the update of parameters, gauge and FOV. This merge request rearranges the code to take into account these updates. Additionally and most important the code for initialization of the rotator is totally refactored. The old routine (with access to "CaptureDeviceAdaptor") did not return the absolute rotator angle at all! It is now replaced with a direct call to the device. As one can see, it was necessary to delay this call for 1sec in the release version.

  • Add rotator "Flip Policy": This (global) policy is an answer to this question and to this wish. It's now possible to define how the rotator reacts after a flip or if the result of a solved reference image reports a different pierside respective to the actual mount pierside. "Preserve Rotator Angle" will keep the rotator position and the camera is virtually rotated by 180°. "Preserve Position Angle" will keep the camera position angle. The rotator always turns the camera to the original position angle and the image will show the original star arrangement. Flip Policy can be altered in the StellarSolver Options under "Rotator Settings".

  • Remove "enforcedJobPA": With the new "Flip Policy" this option is obsolete.

  • Display current policy in rotatorsettings

  • Overhaul user interface

  • Optimize program flow

  • Add notification and debug message

  • Encapsulate sampling of rotator properties

Edited by Toni Schriber

Merge request reports