Skip to content

Draft: ECMGenerateQmlTypes: don't modify local source code

Dawid Wrobel requested to merge wrobelda/extra-cmake-modules:ECMGenerateQmlTypes_fix into master

This is a proposed solution to fix https://bugs.kde.org/show_bug.cgi?id=446050

Modifying the source-code makes it impossible to use it with CMAKE_DISABLE_SOURCE_CHANGES. Since we're installing the file into a final DESTINATION folder, is having that auto-generated file shipped with the source code even necessary?

If so, maybe an alternative solution is to make the ECMGenerateQmlTypes module respect CMAKE_DISABLE_SOURCE_CHANGES switch and skip the local source code modification if enabled.

BUG: 446050

Edited by Dawid Wrobel

Merge request reports