Skip to content

Hide IncidenceBase fields, to enforce uniform use of setFieldDirty()

Glen Ditchfield requested to merge gditchfield/kcalendarcore:privatize-incidencebase into master

Continuation of !45 (merged)

I noticed some oddities in the old code and "fixed" them; reviewers, please consider whether there was some subtle reason for the code being the way it was.

  • addComment(), removeComment(), clearComments(), addContact(), removeContact(), clearContacts(), and setUrl() didn't have update()/updated() pairs.
  • addComment() and clearComments() didn't dirty their field, but removeComment() did.
  • shiftTimes() dirtied FieldDtEnd (which isn't in IncidenceBase) but not FieldDtDue.

Merge request reports