Skip to content

AbstractKCM,SimpleKCM: Unify header/footer

ivan tkachenko requested to merge work/ratijas/kcm-unity into master

AbstractKCM,SimpleKCM: Unify OverlaySheet detection, port to cool iterators

AbstractKCM,SimpleKCM: Unify header/footer content swapping

Drop some extra complexity from the swapping algorithm leveraging parent chain management to Page::header and Padding::contentItem setters, and stop messing with visibility.

SimpleKCM: Drop unnecessary id qualifier from the bindings at the top-level component

SimpleKCM: Port header's wrapper from QQC2.Control to Kirigami.Padding

The patch c2469298 removed explicit zeroing of header Control's individual padding values, giving way for QQC2 styles to override them in potentially undesirable ways (and in fact, that's what our qqc2-desktop-style does, but conveniently it matches the value 6 just as the margin property's comment says). Let's port this thing to a simple Kirigami.Padding, so we don't have to worry about it anymore.

As a drive-by change, move the contentVisible property to the top-level component to shave off creation of one unnecessary meta-object at runtime.

Overall, SimpleKCM now matches the implementation of AbstractKCM.

AbstractKCM,SimpleKCM: Stop overlapping the 1px of content with a header Separator

Just use a regular Column layout.

Replaces !220 (closed) and the much older kdeclarative!202 (closed)

Merge request reports