Skip to content

KSettings::Dialog: port away from Dispatcher

Ahmad Samir requested to merge work/ahmad/dispatcher-phase-out into master
  • In KCMultiDialog, OK/Apply clicked() signals are connected to slots that emit KCMultiDialog::configCommitted(), so no need to connect to OK/Apply again in Dialog, just connect to configComitted()
  • The code in Dispatcher basically did config->sync() and config->reparseConfiguration(), and now this is handled by the code in Dialog (note that config->sync() isn't needed here because reparseConfiguration() already does that)

Users of KSettings::Dialog now need to connect to configCommitted() to run whatever custom code they require, instead of relying on Dispatcher::registerComponent() to do that for them.

Edited by Ahmad Samir

Merge request reports