Skip to content

Emit configChanged on every configuration change

Rinigus Saar requested to merge rinigus/kconfig:config_changed into master

From reading documentation, it appears that configChanged is emitted on every change of the configuration. In practice, it does not happen. For example, see https://invent.kde.org/plasma-mobile/plasma-angelfish/-/issues/31

This MR adds emit code for each configuration change. Note that I am rather unfamiliar with KConfig code and maybe I missed some cases where similar emit code needs to be added.

For some reason, though, the signal is emitted at https://invent.kde.org/frameworks/kconfig/-/blob/master/src/core/kcoreconfigskeleton.cpp#L1271 . Not sure what is the idea behind it there. In practice, if we want to save configs on every change, we will get configChange fired from config setter and once from save. So, would be great to know why is this signal emitted in save.

Merge request reports