Skip to content

Port away from deprecated I18N_NOOP

Friedrich W. H. Kossebau requested to merge work/kossebau/porttolazylstring into master

@vkrause @aacid

Some comments on the code with ideas to improve KLazyLocalizedString() API:

  • explicit KLazyLocalizedString() constructor prevents {} init in struct init, is the explicit needed?
  • KLocalizedString(lazyString).toString() seems a repeated usage pattern, should KLazyLocalizedString get a shortcut API, e.g. an own toString()?
  • if (lazyString.untranslatedText()) instead of the old if (lazyString) makes code longer with no real gain -> ki18n!27 (closed) up as proposal to allow the shortcut expression again

Merge request reports