Skip to content

VCardParser: less temporary allocations

Ahmad Samir requested to merge work/ahmad/parser-temporaries into master

Profiling vcardtool_benchmark with heaptrack shows ~60% less temporary allocations. I think this is due to QStringBuilder concatenation which will ultimately allocate a QByteArray, whereas using append() doesn't allocote.

I didn't extend the same change to all the other if else branches, because so far this is the hot path, at least with vcardtool_benchmark.

Merge request reports