Skip to content

Use all-upper-case version variable names (KF consistency)

Friedrich W. H. Kossebau requested to merge work/kossebau/alignversionnamepattern into master

All (but 3 currently) KF modules use UPPERCASE_VERSION pattern for the version macros/variables. So let's be more consistent to allow more writing-by-patterns :)

No plan to backport to KF5, as this is a SC-breaking change. IMHO anyone who might want to have code both compatible with KF5 & KF6 would need to do local support for both variants where needed. lxr.kde.org/search hinted to only one user in KDE repos which though has a KF6 branch where the use might be removed also next? -> https://invent.kde.org/pim/akonadi-contacts/-/blob/kf6/src/akonadi-contacts/standardcontactformatter.cpp#L154

And as this macro is used in preprocessor condition usually, at least I know of no way to add deprecation warnings, so preparing things on the KF5 side might not be possible.

Merge request reports