Skip to content

simplify qrc watching test

Harald Sitter requested to merge work/qrcaway into master

This test was a less sufficiently tooled variant of the existing removeAndReAdd in terms of watching things apper and disappear, which the test asserts does not break when one tries to watch qrc paths. While I get the idea of wanting to have a very truthful test case in our case we have to take reentrancy over reproducibility since the test may be run multipel times in paralla.

I've verified that undoing the qrc escape in addEntry() actually still breaks within the context of removeAndReAdd and so this is a 100% equal replacement for our purposes, while also making things a bit faster since we now don't need to setup a new watch.

This unbreaks parallel runs of the kdirwatch test. Since the test gets compiled for each internal backend we cannot do stuff on shared paths (such as cd'ing home and watching it - we'd run into reentrancy problems)

CCBUG: 387006

Merge request reports