Skip to content

KAboutData: deprecate pluginData() & registerPluginData()

Friedrich W. H. Kossebau requested to merge work/kossebau/deprecateregisterPluginData into master

The concept of a central registry for the metainfo about all plugins as implemented by those methods is now a legacy, with most plugins systems already designed around KPluginMetaData (or the older to-be-deprecated KPluginInfo).

All calls found to these two methods by lxr.kde.org seem legacy code calls with no more real use case behind:

Registration happens only for these ( https://lxr.kde.org/search?_filestring=&_string=registerPluginData ) :

  • for KParts and plugins to KParts (but no consumers of that info known)
  • BlueDevilDaemon registering the data of its KDEDModule (no consumers of that info known)
  • Anything still relying on kdelibs4support's KGenericFactoryBase -> KGenericFactory (deprecated anyway)

And the existing calls querying the registry seem to be done for component names for which no data was registered before ( https://lxr.kde.org/search?_filestring=&_string=pluginData%5C%28&_casesensitive=1 ):

  • KCModule(KAboutData::pluginData(QLatin1String("kcm_foobar")) (which then return nullptr in all those cases, the KAboutData with KCModules seems to be used for KAuth rule matching only, using the componentname) KIO's FilterOptions in that list also is a KCModule subclass, passing on the KAboutData to the KCModule constructor.

So seems all defunc legacy code which should be wiped out.

@mwolff @dfaure @aacid @nicolasfella

Merge request reports