Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • K KDBusAddons
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 1
    • Merge requests 1
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • FrameworksFrameworks
  • KDBusAddons
  • Merge requests
  • !5

Fix DesktopStartup ID handling

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged David Edmundson requested to merge work/startup_id into master Jan 04, 2021
  • Overview 12
  • Commits 1
  • Pipelines 0
  • Changes 2

The parsing of DESKTOP_STARTUP_ID to the newly spawned application was broken. QXCBConnection in the constuctor runs:

    m_startupId = qgetenv("DESKTOP_STARTUP_ID");
    qunsetenv("DESKTOP_STARTUP_ID");

Therefore it won't be available as the env here which is always after the platform has loaded.

The handling of startupIDs was effectively completely missing with a TODO. I have effectively opted for the documented solution 2. For creating new windows, everything is automatic. For raising an existing window it is up to the client to handle the startup ID using the value stored via QX11Info.

In the worst case is we attach now obsoleted startupIDs to new windows, but that should be no worse than not having any startup IDs.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: work/startup_id