Skip to content
  • Christoph Wolk's avatar
    KeySequenceItem: be Accessible.Button, not Checkbox · 65e9dd6b
    Christoph Wolk authored and Nate Graham's avatar Nate Graham committed
    KeySequenceItem is visually a button, and derives from the QtQuick.Controls
    type Button. It has some checkbox-like properties though, including a checked
    property for internal use, and QtQuick identifies it as a checkbox. This has
    two negative a11y consequences: first, it is confusing that something that is
    semantically an action (recording a keyboard shortcut sequence) is announced
    as a control that represents boolean state to users that can't see it. Second,
    the internal use of checked toggles it more than once during regular operation
    (to record whether recording is in progress) and so the user is exposed to
    multiple unnecessary announcements of "checked" "not checked".
    
    This change explicitly sets the role Accessible.Button explicitly, solving this
    problem for all direct uses of KeySequenceItem.
    65e9dd6b
Loading