Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • K KDNSSD Framework
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Artifacts
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • FrameworksFrameworks
  • KDNSSD Framework
  • Merge requests
  • !3

Revert "Switch from custom K_D to Q_DECLARE_PRIVATE_D & Q_D"

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Friedrich W. H. Kossebau requested to merge work/kossebau/fixbadcast into master Feb 14, 2021
  • Overview 2
  • Commits 1
  • Pipelines 0
  • Changes 10

Q_DECLARE_PRIVATE_D uses reinterpret_cast with the d member in the defined methods, which results in bad casting with the multi-inheritance subclasses of ServiceBasePrivate.

Switch to use KDNSSD_D instead of K_D to reduce risk of potential clashes.

This reverts commit e8f08295.

BUG: 432949

@dfaure @mdawson @arojas

David, I would ask for a follow-up release of kdnssd 5.79, once approved.

Uploading for review while still testing some more locally, but almost sure this is the cause and fix.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: work/kossebau/fixbadcast