Skip to content

[TaglibWriter] Fix memory leak when updating Cover images in ASF (WMA)

Stefan Brüns requested to merge bruns/kfilemetadata:fix_taglibwriter_memleak into master

Some tag lists in Taglib (ID3v2, Flac, Ogg) transfer ownership of Frames when these are updated, while other (ASF, Mp4) take the data by value, i.e. copying it.

The ASF writing code leaked the heap allocated PictureFrame after appending (copying) its value to the tag list.

Add comments everwhere the ownership is transferred from the calling code to the tag list.

Detected by asan.

Merge request reports