Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
K
KGlobalAccel
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 1
    • Merge Requests 1
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Frameworks
  • KGlobalAccel
  • Merge Requests
  • !10

Merged
Opened Dec 02, 2020 by David Edmundson@davidedmundsonDeveloper

Avoid autostarting kglobalaccel when shutting down

  • Overview 12
  • Commits 1
  • Changes 2

Order of our service teardown is somewhat undefined. kglobalaccel5 can be closed before plasmashell.

On plasma exit we call setInactive/unregister on various kglobalaccel actions and accidentally spawn kglobalaccel again.

If kglobalaccel is already closed, our actions aren't registered. There is no point waking it up to try and remove an action. Use of the setAutoStartService flag was chosen over checking if the kglobalaccel service is still registered as that is still racey.

This was always slightly broken, but changes in the ecosystem means the impact this has has worsened.

CCBUG: 429415

Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Reference: frameworks/kglobalaccel!10
Source branch: work/closedown