Skip to content

Draft: trash: offer interactive options for insufficient space failures

Nate Graham requested to merge ngraham/kio:interactive-trash-options into master

When the user tries to trash a file that's larger than the trash, or that doesn't fit within the amount of space it has remaining, right now they see an error message that doesn't offer them any next steps. This can be frustrating.

With this commit, now the user will see an interactive message box when they encounter one of these conditions, with the option to delete the too-large file immediately, or empty the trash to make space.

BUG: 431351 FIXED-IN: 5.100

@dfaure @ahmadsamir

Test plan:

  1. set the trash to 0.1% space and try to trash a big file
  2. set the trash to 1 Mb larger than the size of what's in it and try to trash anything else

Draft because the deletion doesn't work properly and I need help figuring out why. The file only seems to actually get deleted when I try to trash it a second time and click the cancel button in the "Delete immediately?" message box.

Merge request reports