Skip to content

RFC: Don't send CMD_CLOSE in SimpleJobPrivate::workerDone

Fabian Vogt requested to merge work/fvogt/dontclosetwice into master

Currently, FileJob::close() actually closes the FileJob twice:

  1. (Application) FileJob::close()
  2. (Worker) WorkerBase::close()
  3. (Worker) FooWorker::close()
  4. (Worker) WorkerBase::finished()
  5. (Application) SimpleJob::finished()
  6. (Application) SimpleJobPrivate::workerDone()
  7. (Application) Worker::send(CMD_CLOSE

RFC because I'm wondering whether I'm missing something.

Edited by Fabian Vogt

Merge request reports