Skip to content

RFC: Don't send CMD_CLOSE in SimpleJobPrivate::slaveDone

Fabian Vogt requested to merge work/fvogt/dontclosetwice into master

Currently, FileJob::close() actually closes the FileJob twice:

  1. (Application) FileJob::close()
  2. (Slave) SlaveBase::close()
  3. (Slave) FooSlave::close()
  4. (Slave) SlaveBase::finished()
  5. (Application) SimpleJob::finished()
  6. (Application) SimpleJobPrivate::slaveDone()
  7. (Application) Slave::send(CMD_CLOSE)

RFC because I'm wondering whether I'm missing something.

Merge request reports