Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • K KIO
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 5
    • Issues 5
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 66
    • Merge requests 66
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Artifacts
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • FrameworksFrameworks
  • KIO
  • Merge requests
  • !1070

KUrlNavigatorPlacesSelector: Update menu only before it shows

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Kai Uwe Broulik requested to merge work/kbroulik/kurlnav-update-menu-on-demand into master Nov 29, 2022
  • Overview 5
  • Commits 1
  • Pipelines 5
  • Changes 2

The menu would be updated quite often, which is wasteful, since it deletes and recreates all actions. The menu also isn't even provided in the default configuration in Dolphin or the file dialog.

This also removes the need to update the teardown action on the fly.


@meven @ahmadsamir

Saves a bunch of temporary allocations Meven found in some other ticket

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: work/kbroulik/kurlnav-update-menu-on-demand