Skip to content

Revert "Introduce PCH to improve build times"

Friedrich W. H. Kossebau requested to merge work/kossebau/revertpch into master

This reverts the CMake code bits of commit 88711c0c.

Had prematurely landed from !1234 (merged) without approval & review, causes warnings & errors with no active maintainer around.

Examples:

[12:23] <krop> here it fails with 'error: is pie differs in PCH file vs. current file'

or see warnings also on CI -> https://invent.kde.org/frameworks/kio/-/jobs/992987/raw:

cc1plus: warning: /builds/frameworks/kio/_build/src/CMakeFiles/KIOPchCore.dir/cmake_pch.hxx.gch: created and used with different settings of %<-fpic%> [-Winvalid-pch]

The additional build variant also results in only one variant being tested on CI (and normal developer builds), resulting in uncaught issues, e.g. includes missing that are otherwise injected by the PCH util header (cmp. also 189649b8).

Using techniques to speed up builds is welcome in general, but it should be done organized & together.

Merge request reports