Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • K KIO
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 5
    • Issues 5
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 65
    • Merge requests 65
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Artifacts
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • FrameworksFrameworks
  • KIO
  • Merge requests
  • !1314

KCoreDirLister::nameFilter: revert to non-partial matching again

  • Review changes

  • Download
  • Patches
  • Plain diff
Open Friedrich W. H. Kossebau requested to merge work/kossebau/wildcardfilter into kf5 Jun 13, 2023
  • Overview 0
  • Commits 1
  • Pipelines 2
  • Changes 2

Commit 192b2baf added the un-anchoring of the regex pattern in setNameFilter().

Having unanchored matches though breaks some expectations from wildcard expressions as used with name filters (see also examples in the API docs of setNameFilter). E.g. for "*.po" one would only expect files with suffix "po" only, not also "pot" or any other suffixes starting with "po". Similar "*.tar" should not deliver "tar.gz" files etc.

The olc QRegExp code also was just using QRegExp(filter, Qt::CaseInsensitive, QRegExp::Wildcard) so also not doing partial matches of any kind.

Edited Jun 13, 2023 by Friedrich W. H. Kossebau
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: work/kossebau/wildcardfilter