Skip to content

KUrlNavigator: Block signals on toggleEditMode button during switchView

Kai Uwe Broulik requested to merge work/kbroulik/kurlnavigator-yo-dawg-i-heard-you-like-toggling into master

QAbstractButton::toggle is emitted in response to both user and programmatic changes, so us doing setChecked during switchView would also trigger the slot, applying the URL immediately, leading to spurious location changes.

In fe08d1ef it was explicitly changed to "toggled" for automated testing reasons, so an explicit QSignalBlocker is used instead.

Hit Ctrl+L in Dolphin, switched locations, hit Ctrl+L again, it would no longer switch to a random location.

@mart @meven @cullmann

Merge request reports