Skip to content

KFilePlacesItem: Cache groupType

Kai Uwe Broulik requested to merge work/kbroulik/kfileplaces-cache-group into master

It's called a lot. Particularly KProtocolInfo is quite slow when a protocol is was not found.

It’s called like 4,000 times on Dolphin startup for me… spends 5ms there for me. With this it’s less than half a ms.

The i18n stuff for groupName is also surprisingly expensive, so I left the cache for it as-is.

Also found on dev session where I don’t have kio-extras it would read my bookmarks and find that there’s no sftp and spend enormous amounts of time reloading the protocol info cache hoping to find it.

Verified that editing a bookmark and changing it from e.g. local file to remote:/ moves the group. Didn’t try storage stuff.

Edited by Kai Uwe Broulik

Merge request reports