Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • K KIO
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 2
    • Issues 2
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 79
    • Merge requests 79
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • FrameworksFrameworks
  • KIO
  • Merge requests
  • !250

KFileWidget: allow files that begin with a ':' to be selected

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Ahmad Samir requested to merge work/ahmad/filedlg-colon into master Dec 10, 2020
  • Overview 13
  • Commits 1
  • Pipelines 0
  • Changes 3

The issue was that a ':' at the beginning denotes a Qt Resource and in that case QDir::isAbsolutePath() would return true. The bug is fixed by guarding against that condition in slotOk().

Also guard other QDir::isAbsolutePath() usage the same way.

Since this logic will be used in various places use a helper function, isAbsoluteLocalPath() (thanks to dfaure for coming up with that name), in pathhelpers_p.h.

Extend the unit tests.

BUG: 322837 FIXED-IN: 5.78

Edited Dec 11, 2020 by Ahmad Samir
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: work/ahmad/filedlg-colon